[issue9835] ZipFile unix external attributes incorrect for entry written with writestr

2010-09-14 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: This has already been corrected by issue3394, and is at least present in python 2.6. -- nosy: +amaury.forgeotdarc resolution: -> out of date status: open -> closed superseder: -> zipfile.writestr doesn't set external attributes, so files are e

[issue9835] ZipFile unix external attributes incorrect for entry written with writestr

2010-09-11 Thread Thomas Sondergaard
Thomas Sondergaard added the comment: It does know that the entry is a regular file, and that is the bit of information that is missing in the unix external file attributes. Having said that you do have a point - perhaps it shouldn't record unix external file attributes at all, when the entry

[issue9835] ZipFile unix external attributes incorrect for entry written with writestr

2010-09-11 Thread R. David Murray
R. David Murray added the comment: I'm not very familiar with zipfile, but my immediate reaction is, why should it? It can't know that the file is a unix file, and indeed if the program is running on windows it may not be. Perhaps instead there's something missing in the API to allow you to

[issue9835] ZipFile unix external attributes incorrect for entry written with writestr

2010-09-11 Thread Thomas Sondergaard
New submission from Thomas Sondergaard : For entries written with writestr ZipFile doesn't record the file type in the unix external attributes block. It should set it to "regular file" (S_IFREG). The attached sample creates a zip file. If you inspect it with zipinfo -v, you will see that the