[issue9822] windows batch files are dependent on cmd current directory

Zachary Ware added the comment: Fixed by #21907. -- assignee: -> zach.ware resolution: -> fixed stage: -> resolved status: open -> closed superseder: -> Update Windows build batch scripts versions: +Python 3.5 -Python 3.4 ___ Python tracker

[issue9822] windows batch files are dependent on cmd current directory

Zachary Ware added the comment: Here's the patch that moves external*.bat into PCbuild. I also took the opportunity to give the three files more descriptive names: external.bat -> get_externals.bat, external-common.bat -> get_common_externals.bat, and external-amd64.bat -> get_externals-amd64

[issue9822] windows batch files are dependent on cmd current directory

Zachary Ware added the comment: I just stumbled across this issue in looking for another issue, and this turns out to be of interest to me as well. As such, I've updated sorin's patch to apply to the current default branch, added the same kind of change to the new-since-then clean-amd64.bat,

[issue9822] windows batch files are dependent on cmd current directory

Martin v. Löwis added the comment: > I did not realize the build instructions recommended using the > buildbot tool. It is clearly past time I got around to doing windows > build myself. I'd rather prefer a different setup, also: it would be better if the batch files to get the sources lived i

[issue9822] windows batch files are dependent on cmd current directory

Changes by sorin : Removed file: http://bugs.python.org/file18828/buildbot_curdir.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue9822] windows batch files are dependent on cmd current directory

Changes by sorin : Removed file: http://bugs.python.org/file18829/readme.txt.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9822] windows batch files are dependent on cmd current directory

sorin added the comment: This is true, that this can impact the build process but the changes are assuring that it will always chdir to the right directory. BTW, %~dp0 is the directory when the batch file is located. -- Added file: http://bugs.python.org/file18831/path_for_bug_9822_v1

[issue9822] windows batch files are dependent on cmd current directory

Brian Curtin added the comment: This is just a guess, but it might have to do with how buildbot works, so I'd be careful of changing this. A lot of things (everything?) in that Tools\buildbot folder depend on being run from the top-level directory in order to work correctly. Another example:

[issue9822] windows batch files are dependent on cmd current directory

R. David Murray added the comment: I did not realize the build instructions recommended using the buildbot tool. It is clearly past time I got around to doing windows build myself. Please regenerate the diffs from the top level of the checkout, and we'll see if one of the windows devs feel

[issue9822] windows batch files are dependent on cmd current directory

sorin added the comment: In this case I made the patch on the right branch (py3k). These scripts could be called manually and it doesn't make any sense not to make them work in all cases. Not every Windows developer is using Visual Studio to build things, 'some' of them are using the command

[issue9822] windows batch files are dependent on cmd current directory

R. David Murray added the comment: The general rule for submitting patches is to make them against development trunk (which is currently the py3k branch). Unified diffs from the top level of the checkout are preferred; whole files are not useful. However, it is not clear what bug you are try

[issue9822] windows batch files are dependent on cmd current directory

Changes by sorin : -- keywords: +patch Added file: http://bugs.python.org/file18828/buildbot_curdir.patch ___ Python tracker ___ ___ Py

[issue9822] windows batch files are dependent on cmd current directory

New submission from sorin : Currently most batch files from Tools\buildbot do fail to run if you do not call them from the python source root directory. I already have patched files, but the question is against which branch should I make them, considering that this bug is valid for all versio