[issue9790] ntpath contains imports inside functions

Brian Curtin added the comment: Committed in r84992. Thanks for having a look. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue9790] ntpath contains imports inside functions

Antoine Pitrou added the comment: Patch looks ok, and it would hopefully fix build errors on the XP buildbots :) -- nosy: +pitrou ___ Python tracker ___ _

[issue9790] ntpath contains imports inside functions

Nick Coghlan added the comment: Yeah, I realised shortly after I sent my email in response to the checkin that the original version was covering more cases in that first try-block. I'll defer to you when it comes to exactly which case that NotImplementedError was covering - patch looks good g

[issue9790] ntpath contains imports inside functions

Brian Curtin added the comment: Nick noticed another issue with this, and it actually won't work on pre-Vista versions since we load GetFinalPathNameByHandle at runtime, which is why we had that NotImplementedError. Attaching a patch which should handle this. We only try the import on Windows

[issue9790] ntpath contains imports inside functions

Changes by Brian Curtin : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue9790] ntpath contains imports inside functions

Brian Curtin added the comment: Committed to py3k in r84988 using Nick's second suggestion. -- resolution: -> fixed stage: needs patch -> committed/rejected ___ Python tracker _

[issue9790] ntpath contains imports inside functions

New submission from Brian Curtin : As pointed out by Nick Coghlan on python-dev, ntpath.samefile and ntpath.sameopenfile are vulnerable to deadlock because they contain imports. -- assignee: brian.curtin components: Extension Modules, Windows files: review_email.txt messages: 115761 nos