[issue9752] MSVC Compiler warning in Python\import.c

Daniel Stutzbach added the comment: Committed as r84659. Thanks for the patch! -- stage: patch review -> committed/rejected status: open -> closed type: -> compile error ___ Python tracker ___

[issue9752] MSVC Compiler warning in Python\import.c

Amaury Forgeot d'Arc added the comment: > BTW: should I be using the .patch extension or .diff extension? Both extensions are fine and handled the same way -- ___ Python tracker

[issue9752] MSVC Compiler warning in Python\import.c

Amaury Forgeot d'Arc added the comment: The patch is good, and fixes an incorrect call to the mkdir function. -- nosy: +amaury.forgeotdarc resolution: -> accepted ___ Python tracker ___

[issue9752] MSVC Compiler warning in Python\import.c

Jon Anglin added the comment: How about this: see no-macro.diff BTW: should I be using the .patch extension or .diff extension? -- Added file: http://bugs.python.org/file18798/no-macro.diff ___ Python tracker _

[issue9752] MSVC Compiler warning in Python\import.c

Brian Curtin added the comment: Thanks for looking into that. Since we now know that there is no use for the mode parameter on Windows, let's just remove the mode related stuff (of course leaving it for other OSes). We could then remove the macro and do the #ifdef dance around the mkdir/_mkdi

[issue9752] MSVC Compiler warning in Python\import.c

Jon Anglin added the comment: Visual Studio ships with the source code for the CRT (\Program Files\Microsoft Visual Studio 9.0\VC\crt\src). I looked up _mkdir. It does just call CreateDirectory(path, NULL). If no error occurs it returns zero. If an error occurs, it then converts the result o

[issue9752] MSVC Compiler warning in Python\import.c

Daniel Stutzbach added the comment: As far as I can tell, _mkdir(name) is equivalent to CreateDirectoryA(name, NULL), except one uses errno and the other uses GetLastErrno. It is definitely possible that there's something I don't know, though, and the documentation doesn't explicitly state t

[issue9752] MSVC Compiler warning in Python\import.c

Brian Curtin added the comment: What about using CreateDirectory? -- components: +Build nosy: +brian.curtin ___ Python tracker ___ ___

[issue9752] MSVC Compiler warning in Python\import.c

Jon Anglin added the comment: Windows provides two versions of mkdir in direct.h: int mkdir(const char* dirname) int _mkdir(const char* dirname) The latter is the preferred function because it is conformant to the ISO C++ standard. As you can see, neither function has a mode parameter

[issue9752] MSVC Compiler warning in Python\import.c

New submission from Daniel Stutzbach : 7>..\Python\import.c(1158) : warning C4013: 'mkdir' undefined; assuming extern returning int -- assignee: stutzbach components: Interpreter Core, Windows keywords: easy messages: 115428 nosy: stutzbach priority: low severity: normal stage: needs pa