[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ __

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Roundup Robot added the comment: New changeset 13e6d3cb2ecd by Victor Stinner in branch 'default': Issue #9642: Uniformize the tests on the availability of the mbcs codec http://hg.python.org/cpython/rev/13e6d3cb2ecd -- ___ Python tracker

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Roundup Robot added the comment: New changeset 75b18b10064f by Victor Stinner in branch 'default': Issue #9642: Fix the definition of time.clock() on Windows http://hg.python.org/cpython/rev/75b18b10064f -- ___ Python tracker

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Roundup Robot added the comment: New changeset 7ce685cda0ae by Victor Stinner in branch 'default': Issue #9642: Fix filesystem encoding initialization: use the ANSI code page on http://hg.python.org/cpython/rev/7ce685cda0ae -- nosy: +python-dev ___ P

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

STINNER Victor added the comment: Version 3 of the patch: - fix initialization of the filesystem encoding if HAVE_MBCS is not set - Python fails on the filesystem encoding if it is unable to get the filesystem encoding instead of using UTF-8 - reorganize the definition of time_clock() functi

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

STINNER Victor added the comment: Patch version 2, more complete: use HAVE_MBCS everywhere. -- Added file: http://bugs.python.org/file22566/have_mbcs-2.patch ___ Python tracker _

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

STINNER Victor added the comment: > How do the two patches relate? Oh, I forgot to remove my first patch which was wrong. -- ___ Python tracker ___ _

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Changes by STINNER Victor : Removed file: http://bugs.python.org/file18577/ifdef_mbcs.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Martin v. Löwis added the comment: How do the two patches relate? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

STINNER Victor added the comment: have_mbcs.patch: use HAVE_MBCS define instead of different tests to check if the MBCS codec can be used or not. HAVE_MBCS is defined in unicodeobject.h by: #if defined(MS_WINDOWS) && defined(HAVE_USABLE_WCHAR_T) # define HAVE_MBCS #endif > > We should just c

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Martin v. Löwis added the comment: > mbcs functions don't use the wchar_t type. That's not true. MultiByteToWideChar use LPWSTR, which is a typedef for wchar_t*. These functions assume that Py_UNICODE is the same type as WCHAR. > We should just check that we are compiling under Windows: -1,

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

Amaury Forgeot d'Arc added the comment: It's true that for now, MS_WINDOWS implies HAVE_USABLE_WCHAR_T and PyUnicodeObject directly used as a WCHAR array. I'd prefer a new symbol though. Why not something like HAVE_MBCS_CODEC? -- nosy: +amaury.forgeotdarc

[issue9642] #ifdef and mbcs: don't check for defined(HAVE_USABLE_WCHAR_T)

New submission from STINNER Victor : mbcs codec functions are surrounded by: #if defined(MS_WINDOWS) && defined(HAVE_USABLE_WCHAR_T) (especially in unicodeobject.c and _codecsmodule.c) or #ifdef MS_WIN32 (in unicodeobject.h) or #if defined(MS_WINDOWS) && !defined(__BORLANDC__) (in timemodule