[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: Antoine agreed in IRC that this was an acceptable closure. -- stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue9557] test_mailbox failure under a Windows VM

Roundup Robot added the comment: New changeset 9a184d8211f5 by R David Murray in branch '3.1': #9557: eliminate 3 seconds of static overhead from test_mailbox. http://hg.python.org/cpython/rev/9a184d8211f5 New changeset 268ab32a89a9 by R David Murray in branch '3.2': Merge #9557: eliminate 3 se

[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: All right, so how about I set the add factor to, say, 5, so that if things are mostly in sync it will succeed, and otherwise just ignore your failures :) -- ___ Python tracker __

[issue9557] test_mailbox failure under a Windows VM

Antoine Pitrou added the comment: > Hmm. 411-61=350. Three seconds difference looks a little odd. But > doesn't explain 60 vs 61 making the difference in the test. > > Can you change it back to 60 (or even less) and see what the values > look like when the test fails? Hmm, 60 doesn't fail a

[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: Hmm. 411-61=350. Three seconds difference looks a little odd. But doesn't explain 60 vs 61 making the difference in the test. Can you change it back to 60 (or even less) and see what the values look like when the test fails? It is interesting (and possib

[issue9557] test_mailbox failure under a Windows VM

Antoine Pitrou added the comment: before: os.path.getmtime('cur') = 1301075411.6942866 before: os.path.getmtime('new') = 1301075411.693287 after: os.path.getmtime('cur') = 1301075347.38 after: os.path.getmtime('new') = 1301075347.38 self._box._last_read = 1301075407.365 time.time() = 1301075408.

[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: Could you print out the mtime values that are being set, and the value of self._mbox._last_read? Or, rather, print out the result of calls to os.path.getmtime on the two directories after the mtime is changed. -- ___

[issue9557] test_mailbox failure under a Windows VM

Antoine Pitrou added the comment: > Hmm. You are right, I wasn't thinking clearly, and I copied that > mtime setting call from another test. Now I have no idea why 61 would > work, unless the clock between your virthost and your smb server is > off by a minute? No, they seem exactly synchroni

[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: Hmm. You are right, I wasn't thinking clearly, and I copied that mtime setting call from another test. Now I have no idea why 61 would work, unless the clock between your virthost and your smb server is off by a minute? --

[issue9557] test_mailbox failure under a Windows VM

Antoine Pitrou added the comment: Indeed, 61 seems to work. I don't understand the comment about one-second granularity, shouldn't it be one-minute? (or why do you need 61?) -- ___ Python tracker _

[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: That could be, certainly. The code is depending on the mtime having a resolution of at least one second. Try making the constant 61 instead of 60. If that doesn't work, try putting the mtime back a lot farther and see if that makes it work If it passes w

[issue9557] test_mailbox failure under a Windows VM

Antoine Pitrou added the comment: Well, on my new setup (Windows 7 VM with a Python checkout located on an SMB drive), the test sometimes passes and sometimes fails, regardless of the patch. I suspect that maybe maildir requires atomicity guarantees that a network FS won't provide. --

[issue9557] test_mailbox failure under a Windows VM

R. David Murray added the comment: It is reasonably likely that the attached patch will fix this. It also removes 3 seconds of fixed overhead from the test. -- keywords: +patch nosy: +r.david.murray stage: -> patch review versions: +Python 2.7, Python 3.1, Python 3.3 Added file: http

[issue9557] test_mailbox failure under a Windows VM

Changes by A.M. Kuchling : -- assignee: akuchling -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue9557] test_mailbox failure under a Windows VM

New submission from Antoine Pitrou : I get this failure in test_mailbox under Windows XP running in a qemu virtual machine: == FAIL: test_reread (test.test_mailbox.TestMaildir) --