[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Antoine Pitrou : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Py

[issue9552] ssl build under Windows always rebuilds OpenSSL

Éric Araujo added the comment: Can this be backported, or just closed? -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-li

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Thank you, I've committed in r84993(py3k) I'll close this issue after merging to other branches. -- ___ Python tracker ___ __

[issue9552] ssl build under Windows always rebuilds OpenSSL

Antoine Pitrou added the comment: I'm not really able to review this kind of things. Please commit if you think it is ok. -- ___ Python tracker ___ _

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : Added file: http://bugs.python.org/file18995/py3k_better_build_ssl.zip ___ Python tracker ___ ___ Python-bugs-li

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file18992/py3k_better_build_ssl.zip ___ Python tracker ___ ___ Python-bugs-

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file18974/py3k_better_build_ssl.zip ___ Python tracker ___ ___ Python-bugs-

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Sorry, previous one contained experimental code for another issue. I've attached correct one. -- Added file: http://bugs.python.org/file18992/py3k_better_build_ssl.zip ___ Python tracker

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: - Module/_ssl.c or Module/_hashlib.c are rebuilt + Module/_ssl.c or Module/_hashlib.c won't be rebuilt -- ___ Python tracker ___

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : -- resolution: fixed -> status: closed -> open versions: +Python 2.7, Python 3.1 ___ Python tracker ___ ___

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Hello. Probably I found the better solution for this issue. * build_ssl.py always runs before _ssl.vcproj or _hashlib.vcproj is built. (If entire solution is built, run only onece) * When OpenSSL sources are modified, because build_ssl.py always runs, c

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : -- resolution: -> fixed status: open -> closed versions: -Python 2.7, Python 3.1 ___ Python tracker ___ __

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: I committed py3k_openssl.patch in r84957(py3k). I won't merge into release27-maint nor release31-maint because they are built against openssl-0.9.x and don't have *.asm copy code. -- ___ Python tracker

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Oops, I missed your post. Thank you, I'll commit like that. -- ___ Python tracker ___ ___ Python-

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: I want to commit py3k_openssl.patch for now, because it is much better than before. -- ___ Python tracker ___ ___

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : Added file: http://bugs.python.org/file18949/py3k_openssl_v2.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue9552] ssl build under Windows always rebuilds OpenSSL

Antoine Pitrou added the comment: > Well, I noticed py3k_openssl.patch can suppress rebuild > of OpenSSL nicely, but from IDE, _ssl and _hashlib > are always rebuilt. It doesn't take so much time though. > > With py3k_openssl_v2.patch, we can supress OpenSSL and > python project rebuild nicely,

[issue9552] ssl build under Windows always rebuilds OpenSSL

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file18948/py3k_openssl_v2.patch ___ Python tracker ___ ___ Python-bugs-list

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Thank you for the test. Well, I noticed py3k_openssl.patch can suppress rebuild of OpenSSL nicely, but from IDE, _ssl and _hashlib are always rebuilt. It doesn't take so much time though. With py3k_openssl_v2.patch, we can supress OpenSSL and python project

[issue9552] ssl build under Windows always rebuilds OpenSSL

Antoine Pitrou added the comment: > This is the patch I'm thinking of. I confirmed this works > on VS8.0. (After replaced "..\\.." with "..\\..\\..") Works here too (VS 2008)! -- ___ Python tracker ___

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: This is the patch I'm thinking of. I confirmed this works on VS8.0. (After replaced "..\\.." with "..\\..\\..") E:\PYTHON~1\py3k\PC\VS8.0>python_d.exe build_ssl.py Release Win32 -a Found a working perl at 'C:\Perl\bin\perl.exe' Found an SSL directory at '..\

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: - only when + when P.S. I cannot figure out how to solve this error. http://www.python.org/dev//buildbot/builders/x86%20Windows7%203.x/builds/1593/steps/compile/logs/stdio -- ___ Python tracker

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: I'll revert my commits because I noticed after perl source like openssl-1.0.0a/crypto/x86cpuid.pl was modified, unnecessary rebuild happened again. Appropriate fix will be "only copies *.asm if there are not in tmp32/" as comments in PCBuild/build_ssl.py sai

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Thanks. I've committed in r84902(py3k). -- resolution: -> fixed status: open -> closed versions: +Python 2.7, Python 3.1 ___ Python tracker

[issue9552] ssl build under Windows always rebuilds OpenSSL

Antoine Pitrou added the comment: The patch works here (VS 2008). -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: Here is the result of second run. -- ビルド開始: プロジェクト: _ssl, 構成: Debug Win32 -- ビルド前のイベントを実行しています... Can not find a suitable PERL: NO perl interpreters were found on this machine at all! Please install ActivePerl and ensure it appears on your path No

[issue9552] ssl build under Windows always rebuilds OpenSSL

Hirokazu Yamamoto added the comment: I hope attached patch will fix this. I used shutil.copy2 to retain modified time. (Actually, I tested on VS8.0 with equivalent change, I didn't test this file directly) -- keywords: +patch nosy: +ocean-city Added file: http://bugs.python.org/file189

[issue9552] ssl build under Windows always rebuilds OpenSSL

New submission from Antoine Pitrou : The build steps for _ssl and _hashlib under Windows always rebuild the same intermediate files, even if no change was recorded since the last build. This makes building the whole project longer than it should be. Here is the (trimmed) log: -- Début de