[issue9441] increase logging handlers test coverage

Vinay Sajip added the comment: Fix checked into release32-maint (r88651). -- resolution: accepted -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker __

[issue9441] increase logging handlers test coverage

Vinay Sajip added the comment: You're right about there not being tests, but if there had been, they would be using the PyWin32 libraries as well and so would need to be reimplemented (if the purpose is to remove the dependency). Perhaps ctypes would be an alternative implementation approach.

[issue9441] increase logging handlers test coverage

Brian Curtin added the comment: It would be nice to see tests for NTEventLogHandler, as there are currently none. I looked into implementing NTEventLogHandler's Win32 calls in a C extension rather than requiring a third-party module, but stopped once I realized there weren't any tests. I may

[issue9441] increase logging handlers test coverage

Vinay Sajip added the comment: Okay, I've temporarily commented out TimedRotatingFileHandlerTest tests, while I investigate further. Let's see how the buildbots cope now. -- resolution: fixed -> accepted stage: committed/rejected -> commit review __

[issue9441] increase logging handlers test coverage

R. David Murray added the comment: It looks like we are getting buildbot failures as a result of this checkin: http://www.python.org/dev/buildbot/all/builders/i386 Ubuntu 3.x/builds/2216/steps/test/logs/stdio -- nosy: +r.david.murray status: closed -> open _

[issue9441] increase logging handlers test coverage

Vinay Sajip added the comment: Okay, the tests now pass and I've committed the path to py3k (r84864). Thanks, Tom and Alexander. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> feature request ___ Python track

[issue9441] increase logging handlers test coverage

Vinay Sajip added the comment: Tom, thanks for the patch. If I apply it I get an error at shutdown when run with the command python3.2 regrtest.py test_logging test_logging i.e. when I run test_logging twice. If I use python3.2 regrtest.py test_logging there are no errors. I haven't had tim

[issue9441] increase logging handlers test coverage

Changes by Vinay Sajip : -- assignee: -> vinay.sajip nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue9441] increase logging handlers test coverage

Tom Dunham added the comment: Good point, thank you. I've updated the patch. -- Added file: http://bugs.python.org/file18313/rotating_file_handlers.patch ___ Python tracker ___ _

[issue9441] increase logging handlers test coverage

Alexander Belopolsky added the comment: I noticed that you use timedelta.total_seconds in secs which returns a float while no test covers fractional number of seconds. While not a problem with your choice of tests, equality comparison of floating point values commonly leads to fragile tests.

[issue9441] increase logging handlers test coverage

New submission from Tom Dunham : Some regression tests for logging handlers, brings coverage up from 37% to 52%. Mainly tests to rotating file handlers. -- components: Library (Lib) files: rotating_file_handlers.patch keywords: patch messages: 112171 nosy: Tom priority: normal severity: