[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Antoine Pitrou added the comment: The patch was finally committed in r84653. Thanks to everyone who participated in this. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Antoine Pitrou added the comment: For the record, here are the unladen swallow benchmark results against stock py3k: ### pickle ### Min: 1.644222 -> 0.812691: 2.0232x faster Avg: 1.652311 -> 0.814994: 2.0274x faster Significant (t=297.660908) Stddev: 0.00594 -> 0.00207: 2.8732x smaller ### un

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Antoine Pitrou added the comment: Ok, this patch merges my changes with Alexandre's previous patch. Performance is similar as the previous posted patch. -- Added file: http://bugs.python.org/file18779/pickle_optimizations5.diff ___ Python tracker <

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Antoine Pitrou added the comment: Gosh. My patch is based on an outdated patch :( -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Antoine Pitrou added the comment: Here is a patch. Benchmark numbers: * dumps(): ./python -m timeit -s "import pickle, io; d={(x, 'a'): x for x in range(1)}" "pickle.dumps(d)" -> before: 100 loops, best of 3: 7.47 msec per loop -> after: 100 loops, best of 3: 2.45 msec per loop * loads

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Alexandre Vassalotti added the comment: Antoine, I fixed these issues in the latest patch posted on Rietveld. Also, Skip added the buffer limit in Unladen Swallow (see msg112956). We just need to merge that. -- Added file: http://bugs.python.org/file18777/issue1694050_19001.diff.txt

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Antoine Pitrou added the comment: The patch doesn't apply cleanly anymore. Furthermore, I discovered some additional issues: - load, dump, loads and dumps from the _pickle module were never used because they were shadowed by the same functions in pickle.py - once the C functions above are enab

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Alexandre Vassalotti added the comment: Ah, that's right Skip. You did fixed it in Unladen Swallow's trunk. I will take a look at your solution. http://code.google.com/p/unladen-swallow/source/diff?spec=svn1167&r=1038&format=side&path=/trunk/Modules/cPickle.c&old_path=/trunk/Modules/cPickle.c&

[issue9410] Add Unladen Swallow's optimizations to Python 3's pickle.

Changes by Georg Brandl : -- title: Add Unladden Swallow's optimizations to Python 3's pickle. -> Add Unladen Swallow's optimizations to Python 3's pickle. ___ Python tracker ___