[issue9294] Dead code in Objects/object.c

2010-07-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you! The patch was committed in r83184 (py3k) and r83185 (3.1). -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue9294] Dead code in Objects/object.c

2010-07-25 Thread Grant Limberg
Changes by Grant Limberg : Removed file: http://bugs.python.org/file18198/internal_print_non_recursive.patch ___ Python tracker ___ ___ Python

[issue9294] Dead code in Objects/object.c

2010-07-25 Thread Grant Limberg
Grant Limberg added the comment: On second thought, internal_print() doesn't look like it's needed anymore as it's only called by PyObject_Print() and is no longer recursive. This second patch moves internal_print()'s function body into PyObject_Print and removes the internal_print function.

[issue9294] Dead code in Objects/object.c

2010-07-25 Thread Grant Limberg
Grant Limberg added the comment: It looks like at one point, internal_print was a recursive function, but this is no longer the case. I've updated the function parameters to no longer contain the "nesting" parameter and removed the if block shown in this case. -- keywords: +patch nos

[issue9294] Dead code in Objects/object.c

2010-07-18 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue9294] Dead code in Objects/object.c

2010-07-18 Thread Antoine Pitrou
New submission from Antoine Pitrou : internal_print() is called from only one place, with the `nesting` argument wired to 0, therefore the following chunk of code in internal_print() never gets a chance to be executed: if (nesting > 10) { PyErr_SetString(PyExc_RuntimeError, "print