[issue9272] CGIHTTPServer poisons os.environ

Senthil Kumaran added the comment: Fix committed in revision 85202 (py3k), r85203 (release31-maint), r85204(release27-maint). I had change the patch to use copy.deepcopy instead of os.environ.copy() because for the purposes of test os.environ was masked with EnvironmentGuard which does not ha

[issue9272] CGIHTTPServer poisons os.environ

Georg Brandl added the comment: ISTM that the attached patch is trivial enough not to require any contributor agreement or copyright assignment, at least if we change "Ma Test CGI Server v1.0" to something neutral. -- ___ Python tracker

[issue9272] CGIHTTPServer poisons os.environ

anatoly techtonik added the comment: I still haven't received answers on the licensing questions in developer's mailing list. After the amount of negative feedback received I decided not to continue. But I am still interested in constructive discussion to get satisfying and full answers to th

[issue9272] CGIHTTPServer poisons os.environ

R. David Murray added the comment: Anatoly, last we heard you did not wish to sign the contributor agreement and so were not submitting patches. We are respecting your wishes by not applying this. Have you changed your mind? -- ___ Python tracker

[issue9272] CGIHTTPServer poisons os.environ

anatoly techtonik added the comment: So.. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue9272] CGIHTTPServer poisons os.environ

Changes by Éric Araujo : -- stage: unit test needed -> patch review versions: -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list

[issue9272] CGIHTTPServer poisons os.environ

Senthil Kumaran added the comment: The patch and the tests look good. I could verify it too. I shall commit it. -- assignee: -> orsenthil resolution: -> accepted ___ Python tracker ___

[issue9272] CGIHTTPServer poisons os.environ

anatoly techtonik added the comment: Ok. os.environ seems to be shared between threads. Here is updated patch. -- Added file: http://bugs.python.org/file18102/9272.CGIHTTPServer-poisons-os.environ.patch ___ Python tracker

[issue9272] CGIHTTPServer poisons os.environ

anatoly techtonik added the comment: The test is hard to write. The server is launched in a separate thread. Any ideas how to check os.environ there? -- ___ Python tracker ___ _

[issue9272] CGIHTTPServer poisons os.environ

Georg Brandl added the comment: I don't think a deepcopy of the environment is necessary here. environ.copy() is just fine. Other than that, I agree with Eric. -- nosy: +georg.brandl ___ Python tracker _

[issue9272] CGIHTTPServer poisons os.environ

Eric Smith added the comment: The change looks reasonable to me. It needs a test. -- nosy: +eric.smith stage: -> unit test needed ___ Python tracker ___

[issue9272] CGIHTTPServer poisons os.environ

anatoly techtonik added the comment: Patch queue with other minor fixes you may consider useful http://bitbucket.org/techtonik/http.server-patches/qseries -- ___ Python tracker

[issue9272] CGIHTTPServer poisons os.environ

Changes by R. David Murray : -- components: +Library (Lib) nosy: +orsenthil, r.david.murray type: -> behavior versions: +Python 3.1 ___ Python tracker ___ ___

[issue9272] CGIHTTPServer poisons os.environ

Changes by anatoly techtonik : -- keywords: +patch Added file: http://bugs.python.org/file18024/9272.CGIHTTPServer-poisons-os.environ.patch ___ Python tracker ___ ___

[issue9272] CGIHTTPServer poisons os.environ

New submission from anatoly techtonik : When CGIHTTPServer prepares to start child CGI program it modifies global os.environ. This implicitly changes parents application state if it also relies on some of CGI environment variables. -- messages: 110418 nosy: techtonik priority: normal s