[issue9189] Improve CFLAGS handling

Jed Brown added the comment: Undefined variables are still a problem: $ echo 'FROTZ = ${CFLAGS}' > make.py3 $ python3 Python 3.3.1 (default, Apr 6 2013, 19:03:55) [GCC 4.8.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import distutils.sysconfig >>> dist

[issue9189] Improve CFLAGS handling

Changes by Brett Cannon : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue9189] Improve CFLAGS handling

Éric Araujo added the comment: I think this report can be closed now. -- status: pending -> open ___ Python tracker ___ ___ Python-bug

[issue9189] Improve CFLAGS handling

Stefan Krah added the comment: Since I was the one who reopened this: The issues I found were fixed in r85358 and #9047 seems to be ok now. Setting to pending. -- resolution: -> fixed stage: -> committed/rejected status: open -> pending ___ Python

[issue9189] Improve CFLAGS handling

Stefan Krah added the comment: r85358 fixes the failures in test_sysconfig. The duplicate LDFLAGS are still present, but if it is generally accepted that make-LDFLAGS should be appended to configure-LDFLAGS, then I don't see any way around that. As for me, this could be closed again. Did Antoin

[issue9189] Improve CFLAGS handling

Roumen Petrov added the comment: -1 for the changes. Please restore to previous state. The patch break all uses of well documented build variables. -- nosy: +rpetrov ___ Python tracker

[issue9189] Improve CFLAGS handling

Éric Araujo added the comment: Bugs that may be related: #4010 and #9437 Jeffrey, it would be great if you could have a look at those too. Thanks in advance. -- ___ Python tracker

[issue9189] Improve CFLAGS handling

Ronald Oussoren added the comment: issue9047 is related to the issue Stefan mentions -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue9189] Improve CFLAGS handling

Stefan Krah added the comment: This is what happens. In the Makefile, I have: CONFIGURE_LDFLAGS= -fprofile-arcs PY_LDFLAGS= $(CONFIGURE_LDFLAGS) $(LDFLAGS) But since LDFLAGS=-fprofile-arcs is in the environment, too, we get the duplication. The sysconfig issue is related. In Lib/sys

[issue9189] Improve CFLAGS handling

Changes by Éric Araujo : -- components: +Build nosy: +eric.araujo type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailin

[issue9189] Improve CFLAGS handling

Changes by Éric Araujo : Removed file: http://bugs.python.org/file18062/smime.p7s ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue9189] Improve CFLAGS handling

Stefan Krah added the comment: Starting with r82746 in py3k, I'm getting duplicate LDFLAGS in sysconfig: make distclean export BASECFLAGS="-ftest-coverage -fprofile-arcs" export LDFLAGS="-fprofile-arcs" ./configure make $ ./python Python 3.2a0 (py3k:82746M, Aug 16 2010, 00:25:49) [GCC 4.1.3

[issue9189] Improve CFLAGS handling

Jeffrey Yasskin added the comment: Oops, sorry about that. Is the fix to change LDSHARED to LDSHARED= $(CC) $(PY_LDFLAGS) -bundle -undefined dynamic_lookup ? -- ___ Python tracker __

[issue9189] Improve CFLAGS handling

Ronald Oussoren added the comment: On 9 Jul, 2010, at 20:55, Jeffrey Yasskin wrote: > > Jeffrey Yasskin added the comment: > > Oops. Thanks for telling me. Fixed in r82753. I'm pretty sure this patch broke universal builds on OSX. Not the python build itself, but building 3th-party extensi

[issue9189] Improve CFLAGS handling

Jeffrey Yasskin added the comment: Oops. Thanks for telling me. Fixed in r82753. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue9189] Improve CFLAGS handling

Mark Dickinson added the comment: Jeffrey, the Linux buildbots are showing some distutils failures that look like they might be related to this change. For example: http://www.python.org/dev/buildbot/all/builders/amd64%20gentoo%203.x/builds/1351 test output contains: ===

[issue9189] Improve CFLAGS handling

Jeffrey Yasskin added the comment: Hearing no further comments, I've committed this as r82746. Let me know if it breaks anything. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue9189] Improve CFLAGS handling

Changes by Ronald Oussoren : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue9189] Improve CFLAGS handling

Jeffrey Yasskin added the comment: > Passing in user values to CFLAGS on configure should already work > without the patch. Since the user's CFLAGS settings are overridden by Python's OPT settings, it doesn't already work without the patch. > I'm not sure why you'd want to modify CFLAGS on Mak

[issue9189] Improve CFLAGS handling

Marc-Andre Lemburg added the comment: Jeffrey Yasskin wrote: > > New submission from Jeffrey Yasskin : > > Patch at http://codereview.appspot.com/1749042. > > The idea here is to let the user set CFLAGS on either configure or make (or > both), and have later settings appear later in the $CC

[issue9189] Improve CFLAGS handling

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue9189] Improve CFLAGS handling

Brett Cannon added the comment: Just to say what I said in my Rietveld review of the patch: I support the approach Jeffrey is taking and the patch looks good. -- ___ Python tracker

[issue9189] Improve CFLAGS handling

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9189] Improve CFLAGS handling

New submission from Jeffrey Yasskin : Patch at http://codereview.appspot.com/1749042. The idea here is to let the user set CFLAGS on either configure or make (or both), and have later settings appear later in the $CC command line. I left OPT, BASECFLAGS, and EXTRA_CFLAGS around in case people