[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Antoine Pitrou added the comment: Fixed in r84635, r84636, r84638 (3.x) and r84637 (2.7). Also prompted the creation of issue9804. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Dave Malcolm added the comment: "I don't think this" was of course a browser misfire; I meant to type "I don't think this should block committing this fix" -- ___ Python tracker ___

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Dave Malcolm added the comment: One minor quibble with the patch: In the line: while i < field_length: you're trusting that field_length has a sane value. If field_str points somewhere readable, and field_length is huge (e.g. 0xfff), then gdb could sit there for a while reading all th

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Dave Malcolm added the comment: where "works" means: all tests in test_gdb.py were run, and passed. This was with a --with-pydebug-build in each case -- ___ Python tracker ___ _

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Dave Malcolm added the comment: Tested with UCS4 gdb: (gdb) python import sys; print hex(sys.maxunicode) 0x10 using latest py3k. Works with both UCS2 and UCS4 builds of py3k -- ___ Python tracker

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Antoine Pitrou added the comment: This is a patch for 3.x, tested in the following situations: - gdb: UCS2, inferior: UCS2 - gdb: UCS2, inferior: UCS4 -- Added file: http://bugs.python.org/file18803/test_gdb2.patch ___ Python tracker

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Antoine Pitrou added the comment: The patch works ok on 2.7 but fails to apply on 3.2. Can you provide a 3.2 patch as well? Also, instead of `sys.maxunicode == 0x10`, it would be better to use something more future-proof such as `sys.maxunicode >= 0x1`. -- ___

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

Dave Malcolm added the comment: The traceback is Traceback (most recent call last): File "/home/antoine/cpython/27/python-gdb.py", line 1084, in to_string return pyop.get_truncated_repr(MAX_OUTPUT_LEN) File "/home/antoine/cpython/27/python-gdb.py", line 183, in get_truncated_repr sel