[issue9173] logger statement not guarded in shutil._make_tarball

Éric Araujo added the comment: I fixed this in 615a29295d5f but forgot to mention the bug number in the commit message. To reproduce the bug, I only had to backport two lines from 3.2, so I did not use your patch. Thanks to both of you nonetheless for the report and help! -- assign

[issue9173] logger statement not guarded in shutil._make_tarball

v_peter added the comment: I think it would be nice to get this test in. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue9173] logger statement not guarded in shutil._make_tarball

Éric Araujo added the comment: Duplicate report #11045 was opened recently; I didn’t remember this report and committed a one-line fix without a test. Should we try to get a test into 3.2.0? -- nosy: +georg.brandl, kelseyhightower, rhettinger ___

[issue9173] logger statement not guarded in shutil._make_tarball

Fred L. Drake, Jr. added the comment: > By the way, the logger argument is not documented in shutil.rst. This documentation issue is distinct from this; this bug affects applications that *don't* use the logger argument. -- ___ Python tracker

[issue9173] logger statement not guarded in shutil._make_tarball

Éric Araujo added the comment: Patch looks good. By the way, the logger argument is not documented in shutil.rst. -- nosy: +eric.araujo stage: -> patch review versions: -Python 2.6, Python 3.3 ___ Python tracker

[issue9173] logger statement not guarded in shutil._make_tarball

v_peter added the comment: Added a test to the patch -- nosy: +v_peter Added file: http://bugs.python.org/file19620/shutil_logger_with_test.py27.patch ___ Python tracker ___

[issue9173] logger statement not guarded in shutil._make_tarball

Changes by Tarek Ziadé : -- assignee: -> tarek versions: +Python 2.6, Python 3.1, Python 3.2, Python 3.3 ___ Python tracker ___ ___ Py

[issue9173] logger statement not guarded in shutil._make_tarball

Changes by Fred L. Drake, Jr. : -- nosy: +tarek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue9173] logger statement not guarded in shutil._make_tarball

Fred L. Drake, Jr. added the comment: Patch looks good, but needs a test. -- keywords: +easy nosy: +fdrake ___ Python tracker ___ ___

[issue9173] logger statement not guarded in shutil._make_tarball

New submission from Paul Smith : A called to logger.info() in shutil._make_tarball is not guarded against the logger being None, and therefore raises an AttributeError if that is the case. -- components: Library (Lib) files: shutil_logger_py27.patch keywords: patch messages: 109364 nosy