[issue9042] Gettext cache and classes

Éric Araujo added the comment: Committed in r85223, r85224, r85225 (resp. 3.2, 3.1, 2.7). Thanks again! -- resolution: accepted -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue9042] Gettext cache and classes

Éric Araujo added the comment: (I’m not sure my last line is unambiguous. I meant : Don’t worry, this will get in shortly.) -- status: pending -> open ___ Python tracker ___ __

[issue9042] Gettext cache and classes

Éric Araujo added the comment: Antoine: Thanks for the correction. I was mistaken about versions some months ago and wrote such misleading comments in a handful of bugs. It has been corrected in some of them but not all. v_peter: You don’t have to do anything, it’s the job of the committer

[issue9042] Gettext cache and classes

v_peter added the comment: Which branches should i make patches for then? release27-maint and release31-maint? -- ___ Python tracker ___

[issue9042] Gettext cache and classes

Antoine Pitrou added the comment: > Unfortunately, 2.6 and 3.1 are stable releases, they only get security > and > documentation fixes. 2.7 is nearly in the same state Well, that's false. 2.7 and 3.1 both receive bug fixes (and this looks like a bug to me :-)). -- nosy: +pitrou versi

[issue9042] Gettext cache and classes

Martin v. Löwis added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue9042] Gettext cache and classes

Éric Araujo added the comment: Looks good. Another +1 from a core dev and I commit this. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue9042] Gettext cache and classes

v_peter added the comment: Here's a second patch with key = (class_, os.path.abspath(mofile))) -- Added file: http://bugs.python.org/file18713/class_cache2.diff ___ Python tracker

[issue9042] Gettext cache and classes

Éric Araujo added the comment: This would avoid the issue with different classes having the same name, but otherwise would not make that much of a difference. -- ___ Python tracker

[issue9042] Gettext cache and classes

Robert Lehmann added the comment: Wouldn't constructing the key as a tuple of (class_, mofile) be much cleaner than making up an artificial key? -- nosy: +lehmannro ___ Python tracker _

[issue9042] Gettext cache and classes

Raymond Hettinger added the comment: The patch looks fine. -- nosy: +rhettinger resolution: -> accepted ___ Python tracker ___ ___ Py

[issue9042] Gettext cache and classes

Éric Araujo added the comment: Relying on str(cls) breaks if two classes have the same name, but I guess this is not a concern outside of the interactive interpreter. Patch looks good to me. -- stage: -> patch review ___ Python tracker

[issue9042] Gettext cache and classes

v_peter added the comment: Any comments on the patch for 3.2? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9042] Gettext cache and classes

Changes by v_peter : -- keywords: +patch versions: +Python 3.2 -Python 2.6 Added file: http://bugs.python.org/file17736/class_cache.diff ___ Python tracker ___ ___

[issue9042] Gettext cache and classes

Éric Araujo added the comment: Thanks for your report. Unfortunately, 2.6 and 3.1 are stable releases, they only get security and documentation fixes. 2.7 is nearly in the same state, since it’s at the release candidate stage. If your bug still applies to 3.2 (branch named “py3k”), please pro

[issue9042] Gettext cache and classes

New submission from v_peter : If you pass gettext.translation a class_ but the mo file you are trying to open already exists in the _translations cache the instance that is returned is an instance of whatever was in the cache and not the class that you requested. I think that if a class is req