[issue9012] Separate compilation of time and datetime modules

Martin v. Löwis added the comment: This issue has been superseded by #14180. __PyTime_DoubleToTimet no longer exists; its successor now lives in pytime.c. -- resolution: -> out of date status: open -> closed superseder: -> Factorize code to convert int/float to time_t, timeval or tim

[issue9012] Separate compilation of time and datetime modules

Mark Lawrence added the comment: @Steve/Zach any interest in this one? -- nosy: +steve.dower, zach.ware ___ Python tracker ___ ___ Pyth

[issue9012] Separate compilation of time and datetime modules

R. David Murray added the comment: No. The problem has nothing to do with the VS version. -- ___ Python tracker ___ ___ Python-bugs-li

[issue9012] Separate compilation of time and datetime modules

Mark Lawrence added the comment: msg111078 refers to r82035 for Visual Studio 2005 (VC8) builds. Given that http://code.activestate.com/lists/python-dev/131023/ refers to VC14 for 3.5 can we close this as out of date? -- nosy: +BreamoreBoy ___ Pyth

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: > it sounds like the patch is ready for commit. there are two pending patches here: time.diff - a hack that makes _time.c look like a module while it is not. add_time_to_vc8_build.diff - a patch for VC 8.0 project file. I don't like time.diff because i

[issue9012] Separate compilation of time and datetime modules

R. David Murray added the comment: Bump. This bug has priority high and it sounds like the patch is ready for commit. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue9012] Separate compilation of time and datetime modules

Changes by MunSic JEONG : -- nosy: +ruseel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue9012] Separate compilation of time and datetime modules

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue9012] Separate compilation of time and datetime modules

Changes by Tim Lesher : Added file: http://bugs.python.org/file18113/add_time_to_vc8_build.diff ___ Python tracker ___ ___ Python-bugs-list mai

[issue9012] Separate compilation of time and datetime modules

Changes by Tim Lesher : Removed file: http://bugs.python.org/file18107/add_time_to_vc8_build.diff ___ Python tracker ___ ___ Python-bugs-list m

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: On Wed, Jul 21, 2010 at 3:58 PM, Tim Lesher wrote: .. > To date, I believe that the attitude toward these older build files has been > "unsupported; use at own risk; patches welcome". > OK, I guess there is little risk in committing this patch. I'll do

[issue9012] Separate compilation of time and datetime modules

Tim Lesher added the comment: No, there's no automated way to keep "legacy" Windows toolchains in sync; short of adopting something like Scons or CMAKE (which I'm *not* suggesting) I don't think I've seen a trustworthy way of doing so. The PCBuild's "readme.txt" states: "You can find build d

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: What about PC/VS7.1/pythoncore.vcproj? Is there some automation in place to keep the project files in sync? ISTM, all the info to generate these should be in setup.py. The patch looks good, but I am hesitant to commit changes that I cannot test.

[issue9012] Separate compilation of time and datetime modules

Tim Lesher added the comment: Added patch that replicates the change in r82035 for Visual Studio 2005 (VC8) builds. -- nosy: +tlesher Added file: http://bugs.python.org/file18107/add_time_to_vc8_build.diff ___ Python tracker

[issue9012] Separate compilation of time and datetime modules

Changes by Alexander Belopolsky : -- stage: committed/rejected -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: I am merging in the nosy list from issue9079 after we had a lengthy discussion there and on IRC about the best way to share code between stdlib extension modules. For the issue9079, we decided to bring the shared code into python core, but this cannot

[issue9012] Separate compilation of time and datetime modules

Changes by Alexander Belopolsky : -- nosy: +tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue9012] Separate compilation of time and datetime modules

Mark Dickinson added the comment: Thanks. Looks like we need a general solution to the problem of shared (non-module) dependencies in modules. So all that's needed is a way to stop _time.o showing up twice in MODOBJS in the Makefile, right? (For some reason, ranlib on OS X doesn't seem to h

[issue9012] Separate compilation of time and datetime modules

Matthias Klose added the comment: yes, same issue with math/cmath. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue9012] Separate compilation of time and datetime modules

Mark Dickinson added the comment: Matthias, does building both the math and cmath modules statically into the interpreter fail in a similar manner? -- ___ Python tracker ___ ___

[issue9012] Separate compilation of time and datetime modules

Matthias Klose added the comment: doesn't work: ranlib libpython3.2.a Modules/_time.o: In function `_PyTime_DoubleToTimet': /scratch/packages/python/3.2/python3.2-3.2~~20100704/build-shared/../Modules/_time.c:11: multiple definition of `_PyTime_DoubleToTimet' Modules/_time.o:/scratch/packages/

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: _time.c is not supposed to be compiled into an extension. It is similar to _math.c - if you add a line _math _math.c to Setup, you get a similar compile error. What needs to be done, however, is to add _time.c to time and datetime lines. See issue901

[issue9012] Separate compilation of time and datetime modules

Matthias Klose added the comment: please find attached a patch to build as a statically linked extension, registering the empty _time module. -- Added file: http://bugs.python.org/file17853/time.diff ___ Python tracker

[issue9012] Separate compilation of time and datetime modules

Changes by Matthias Klose : -- resolution: fixed -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9012] Separate compilation of time and datetime modules

Matthias Klose added the comment: this breaks the build if the time and datetime extensions are built statically into the python interpreter. The build fails with a link error; adding the _time extension to Modules/Setup.dist @@ -160,6 +160,7 @@ #cmath cmathmodule.c _math.c # -lm # complex

[issue9012] Separate compilation of time and datetime modules

STINNER Victor added the comment: > Reopen: r82034 broke Windows build Fixed by r82035. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue9012] Separate compilation of time and datetime modules

STINNER Victor added the comment: Reopen: r82034 broke Windows build http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%203.x/builds/802/steps/compile/logs/stdio --- Build started: Project: pythoncore, Configuration: Debug|Win32 Linking... Creating library D:\cygwin\home\db

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: Committed in r82034. -- stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue9012] Separate compilation of time and datetime modules

Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file17685/issue9012.diff ___ Python tracker ___ ___ Python-bugs-list mai

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: Added new Module/_time.h to the patch. -- Added file: http://bugs.python.org/file17686/issue9012.diff ___ Python tracker ___ _

[issue9012] Separate compilation of time and datetime modules

Changes by Alexander Belopolsky : -- resolution: -> accepted ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue9012] Separate compilation of time and datetime modules

Changes by Alexander Belopolsky : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue9012] Separate compilation of time and datetime modules

Alexander Belopolsky added the comment: Based on IRC discussion, here is a modified patch that places C code in _time.c and creates a stub for _time.h so that future shared definitions can go there. -- Added file: http://bugs.python.org/file17685/issue9012.diff ___

[issue9012] Separate compilation of time and datetime modules

Changes by Alexander Belopolsky : -- keywords: +patch Added file: http://bugs.python.org/file17684/timefunc-split.diff ___ Python tracker ___ _

[issue9012] Separate compilation of time and datetime modules

New submission from Alexander Belopolsky : Here is the history of the issue per Martin v. Löwis on python-dev: """ This was added with r36221 | bcannon | 2004-06-24 03:38:47 +0200 (Do, 24. Jun 2004) | 3 Zeilen Add compil