[issue9003] urllib.request and http.client should allow certificate checking

Roundup Robot added the comment: New changeset 1882157b298a by Benjamin Peterson in branch '2.7': allow passing cert/ssl information to urllib2.urlopen and httplib.HTTPSConnection https://hg.python.org/cpython/rev/1882157b298a -- nosy: +python-dev __

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: Patch committed in r85408. I believe this fixes, at last, the whole issue people were complaining about. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.3 _

[issue9003] urllib.request and http.client should allow certificate checking

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file19189/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9003] urllib.request and http.client should allow certificate checking

Senthil Kumaran added the comment: Yes, it does solve the problem of httplib and urllib2_localnet tests which were hanging with the earlier patch on certain machines.. -- Added file: http://bugs.python.org/file19189/unnamed ___ Python tracker

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: This patch should fix the test hanging issues witnessed on some machines. -- Added file: http://bugs.python.org/file19187/httpcli+urllib3.patch ___ Python tracker _

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: Here is a new patch with doc updates for urllib.request. -- Added file: http://bugs.python.org/file19186/httpcli+urllib2.patch ___ Python tracker __

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: Here is a patch which also adds 'cafile' and 'capath' keyword arguments to urlopen(). -- stage: needs patch -> patch review Added file: http://bugs.python.org/file19185/httpcli+urllib.patch ___ Python tracker

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: > Any chance on folding the HTTPSServer class into http.server? Its API and implementation would first have to be cleaned up. I'd prefer if it were the subject of a separate issue. -- ___ Python tracker

[issue9003] urllib.request and http.client should allow certificate checking

geremy condra added the comment: Any chance on folding the HTTPSServer class into http.server? Geremy Condra -- ___ Python tracker ___ __

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: Here is another patch for http.client containing more tests, including with a mismatching cert. Comments welcome. -- Added file: http://bugs.python.org/file19178/httpcli2.patch ___ Python tracker

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: Here is a preliminary patch for http.client. I think it would be good to have local tests using a custom HTTPS server, too. -- keywords: +patch Added file: http://bugs.python.org/file19162/httpcli.patch ___ Python t

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: Here is the API addition I would suggest for the http.client module: Add two new keyword arguments `context` and `check_hostname` to HTTPSConnection; `context` would allow to pass a SSLContext instance for certificate checking and other options (default None,

[issue9003] urllib.request and http.client should allow certificate checking

Antoine Pitrou added the comment: A big warning is now present (*) in the urllib and httplib documentation pages. Also, once issue1589 is fixed, we can go forward and make {http.client,urllib.request} check hostname and cert if the user gives the location of a bunch of CA certs. (*) see e.g.