[issue8832] automate minidom.unlink() with a context manager

2010-06-09 Thread Éric Araujo
Éric Araujo added the comment: You forgot to close the bug :) Note that if you write “r” or “revision ”, Roundup will make a link out of it. -- resolution: -> accepted status: open -> closed ___ Python tracker

[issue8832] automate minidom.unlink() with a context manager

2010-06-09 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Thank you all. I updated the unittest, and committed this in: revision: 81856 -- stage: -> committed/rejected ___ Python tracker ___ __

[issue8832] automate minidom.unlink() with a context manager

2010-06-08 Thread R. David Murray
R. David Murray added the comment: The test passes if __exit__ doesn't call unlink. Otherwise the patch looks good to me. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue8832] automate minidom.unlink() with a context manager

2010-06-08 Thread Éric Araujo
Éric Araujo added the comment: Looks good to me. -- nosy: +merwok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue8832] automate minidom.unlink() with a context manager

2010-06-08 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: +1 -- nosy: +fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue8832] automate minidom.unlink() with a context manager

2010-06-08 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Any comments? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue8832] automate minidom.unlink() with a context manager

2010-05-27 Thread Kristján Valur Jónsson
New submission from Kristján Valur Jónsson : It is all to easy to forget to "unlink()" minidom documents resulting in huge memory usage. This patch allows to automate that process with a context manager, similar to how files can be closed in the same way: with xml.dom.minidom.parse() as dom: