[issue8810] TZ offset description is unclear in docs

Nick Coghlan added the comment: I agree it makes sense to merge this and #9305, and since the latter has seen more recent activity, I'll do the merge in that direction. -- resolution: -> duplicate stage: patch review -> status: open -> closed superseder: -> Don't use east/west of UTC

[issue8810] TZ offset description is unclear in docs

Stéphane Wirtel added the comment: Hi Martin, Which patch? Thanks -- Stéphane Wirtel - http://wirtel.be - @matrixise -- nosy: +matrixise ___ Python tracker ___

[issue8810] TZ offset description is unclear in docs

Changes by Martin Panter : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8810] TZ offset description is unclear in docs

Alexander Belopolsky added the comment: Isn't this a duplicate of #9305? -- assignee: belopolsky -> versions: +Python 3.5 -Python 3.2 ___ Python tracker ___ _

[issue8810] TZ offset description is unclear in docs

Ben Finney added the comment: Attached is a patch which is more comprehensive (covering the additional locations pointed out to me by ncoghlan), and also consolidating the details into the library documentation so they're not verbosely repeated in so many places. I agree with Nick's position

[issue8810] TZ offset description is unclear in docs

Nick Coghlan added the comment: It turns out these particular docstrings are duplicated all over the place, as time and datetime both wrap the tzinfo method, and there is both the tzinfo ABC as well as the concrete fixed offset subclasses, and this happens in both C and Python. Ben's patch cu

[issue8810] TZ offset description is unclear in docs

Ben Finney added the comment: Here is an updated patch. I examined the implementation in the code for UTC offset and DST handling, and updated the code comments, the docstrings, and the library documentation. -- keywords: +patch nosy: +bignose, ncoghlan Added file: http://bugs.python.o

[issue8810] TZ offset description is unclear in docs

Alexander Belopolsky added the comment: Reverted r81681 and r81682 in r82466 and r82467. It looks like docstring changes intended for utcoffset() landed in a docstring for fromutc(). Given that we are very close to 2.7 release, I am not attempting to improve the docs - just reverting an obvi

[issue8810] TZ offset description is unclear in docs

Alexander Belopolsky added the comment: Benjamin, Is it too late to do anything about this. Apparently Sean committed wrong patch and as a result 2.7 is about to be released with an error in tzinfo.fromutc docstring. This method is confusing enough without documentation bugs. Would you mi

[issue8810] TZ offset description is unclear in docs

Alexander Belopolsky added the comment: Sean, It looks like you committed your first patch rather than your second. Is that what you intended? Also in msg106734, you agree to change "West" to "west", but committed "West." Note that "west" is correct. In English, the West means the western

[issue8810] TZ offset description is unclear in docs

Changes by Alexander Belopolsky : -- resolution: accepted -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue8810] TZ offset description is unclear in docs

Changes by Alexander Belopolsky : -- stage: committed/rejected -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8810] TZ offset description is unclear in docs

Alexander Belopolsky added the comment: > In this case, the docs.python.org link you point to seems > to be correct, saying that it returns a timedelta. This issue is specifically about ReST documentation, not the docstring. I explained in the opening comment that 'It is later explained that i

[issue8810] TZ offset description is unclear in docs

Sean Reifschneider added the comment: Committed to 2.7 in 81681 and 3.x in 81682. -- keywords: +needs review -patch resolution: -> accepted stage: -> committed/rejected status: open -> closed type: -> feature request ___ Python tracker

[issue8810] TZ offset description is unclear in docs

Sean Reifschneider added the comment: I'm fine without (). I thought the direction was generally initial-capped, but I may be wrong there. Let's go with "west". -- ___ Python tracker

[issue8810] TZ offset description is unclear in docs

Éric Araujo added the comment: > timedelta() showing offset from UTC, negative values indicating West of UTC +1 for the last one. Micro nit: I would not put parentheses when referring to the type (we talk about “a list”, not “a list()”). Micro nit: Some languages use case to distinguish direc

[issue8810] TZ offset description is unclear in docs

Sean Reifschneider added the comment: Then how about: timedelta() showing offset from UTC, negative values indicating West of UTC ? -- ___ Python tracker ___ __

[issue8810] TZ offset description is unclear in docs

Sean Reifschneider added the comment: Alternately, here is a patch that just takes the docs.python.org description. -- Added file: http://bugs.python.org/file17496/python-utcoffsetdoc2.patch ___ Python tracker

[issue8810] TZ offset description is unclear in docs

Éric Araujo added the comment: I’m not sure about the “with negative” wording. -- nosy: +merwok ___ Python tracker ___ ___ Python-bugs

[issue8810] TZ offset description is unclear in docs

Sean Reifschneider added the comment: In this case, the docs.python.org link you point to seems to be correct, saying that it returns a timedelta. It is the docstring that says it's minutes east of UTC. I've attached a patch which changes this wording to: timedelta() showing offset from UTC

[issue8810] TZ offset description is unclear in docs

New submission from Alexander Belopolsky : >From >: """ tzinfo.utcoffset(self, dt) Return offset of local time from UTC, in minutes east of UTC. """ This suggests that the return value is an integer represen