[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-17 Thread Daniel Stutzbach
Changes by Daniel Stutzbach : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-17 Thread Daniel Stutzbach
Daniel Stutzbach added the comment: On Fri, Dec 17, 2010 at 2:17 PM, Amaury Forgeot d'Arc wrote wrote: > Err... in r87339 there is a typo in all occurrences of > 'Py_ReprEntr': Py_ReprEnter of course! Well, that's embarrassing. Fixed in r87354. --

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-17 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Err... in r87339 there is a typo in all occurrences of 'Py_ReprEntr': Py_ReprEnter of course! -- nosy: +amaury.forgeotdarc status: closed -> open ___ Python tracker

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-17 Thread Daniel Stutzbach
Daniel Stutzbach added the comment: Committed in r87339. Thanks everyone for the feedback! -- assignee: eric.araujo -> stutzbach keywords: -needs review resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed versions: -Python 2.7 __

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-17 Thread Georg Brandl
Georg Brandl added the comment: Yep, looks good, please commit. -- assignee: d...@python -> eric.araujo nosy: +georg.brandl ___ Python tracker ___ ___

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Éric Araujo
Éric Araujo added the comment: Patch LGTM, except for “As examples” which I’ve never read before (but I’m not a native speaker). -- ___ Python tracker ___ __

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Daniel Stutzbach
Daniel Stutzbach added the comment: Thanks. New patch attached with a cross-reference to reprlib.recursive_repr. -- Added file: http://bugs.python.org/file20072/repr-3.patch ___ Python tracker

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Éric Araujo
Éric Araujo added the comment: Possibly related: #9840 -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Daniel Stutzbach
Changes by Daniel Stutzbach : Added file: http://bugs.python.org/file20071/repr-2.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: > How about if I change the first sentence to the following? > > Properly implementing :attr:`tp_repr` for container types requires > special recursion handling. This looks good to me. -- ___ Python tracker

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Daniel Stutzbach
Daniel Stutzbach added the comment: Good point. My perspective is skewed by all of the time that I spend working on container types. :-) How about if I change the first sentence to the following? Properly implementing :attr:`tp_repr` for container types requires special recursion han

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think this is a bit misleading. These functions are only needed if you are implementing a container. For the general case where you don't display another Python object in your repr() (or you only display objects which are themselves atomic, such as strings

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-12-15 Thread Daniel Stutzbach
New submission from Daniel Stutzbach : Attached is a patch to add documentation for Py_ReprEnter and Py_ReprLeave. Assigning to d...@python for review. -- assignee: stutzbach -> d...@python keywords: +needs review, patch nosy: +d...@python stage: needs patch -> patch review Added file:

[issue8753] Py_ReprEnter and Py_ReprLeave are undocumented

2010-05-18 Thread Daniel Stutzbach
Changes by Daniel Stutzbach : -- assignee: stutzbach components: Documentation nosy: stutzbach priority: normal severity: normal stage: needs patch status: open title: Py_ReprEnter and Py_ReprLeave are undocumented versions: Python 2.7, Python 3.2 ___