[issue8721] urlparse.urlsplit regression in 2.7

2010-05-19 Thread R. David Murray
R. David Murray added the comment: Why would you not want to catch all value errors? I assume (perhaps a bad thing) that distribute will repeat the returned error message in a more user friendly format. If a bug in urlparse returns a spurious ValueError, that will presumably be found (and t

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-19 Thread Sridhar Ratnakumar
Sridhar Ratnakumar added the comment: On 2010-05-19, at 5:00 AM, Tarek Ziadé wrote: > I've fixed the problem on distribute side by catching any ValueError returned > by urlparse (from 2.6 or 2.7 point of view). Catching ValueError will catch *every* ValueError raised, rather than only the in

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-19 Thread Tarek Ziadé
Tarek Ziadé added the comment: Senthil: thx for the pointer. I've fixed the problem on distribute side by catching any ValueError returned by urlparse (from 2.6 or 2.7 point of view). That said, I don't think than catching more invalid URLs in Python 2.7 should be considered as a feature.

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: tarek: Issue2987 has the details on changes made for ipv6 urlparse. Those can't be backported as it's a feature. I would rather like to see whats breaking in distutils2. The url which resulted in this bug in distribute: "http://www.famfamfam.com](http://www

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-19 Thread Tarek Ziadé
Tarek Ziadé added the comment: I couldn't find the relevant commits, but if we didn't do it, ISTM that we should backport the fix in the next 2.6 so it behaves like in 2.7. -- nosy: +tarek ___ Python tracker _

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: FWIW, it should also be noted that RFC asserts square brackets to be valid characters in the hostname portion only and that too when it is a IPv6 url. In the example given, at the query portion, it should be quoted (or percent-encoded) -- __

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-14 Thread R. David Murray
R. David Murray added the comment: Python 2.7b2+ (trunk:81129, May 12 2010, 19:05:17) [GCC 4.4.3] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from urlparse import urlsplit >>> urlsplit('http://www.google.com/search?q=foo&b=df]d&qscrl=1', 'http', True) Sp

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-14 Thread Sridhar Ratnakumar
Sridhar Ratnakumar added the comment: For eg., the following URLs seems to load just fine in my browser: http://www.google.com/search?q=foo&b=df]d&qscrl=1 And, as is the case with the django-cms PyPI page (see referred issue link in msg), such URLs seemed to be practically used in a few pla

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-14 Thread Sridhar Ratnakumar
Sridhar Ratnakumar added the comment: Shouldn't `urlparse` accept non-IPv6 URLs as well - as it always used to - when these URLs can have a single ']'? -- status: pending -> open ___ Python tracker ___

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-14 Thread R. David Murray
R. David Murray added the comment: Why do you think this is a regression? It looks to me like the error message is accurate. (A ']' is valid in the netloc part only when specifying an IPv6 address). -- nosy: +orsenthil, r.david.murray resolution: -> invalid status: open -> pending

[issue8721] urlparse.urlsplit regression in 2.7

2010-05-14 Thread Sridhar Ratnakumar
New submission from Sridhar Ratnakumar : [stor...@nas0 ~]$ python2.6 -c "import urlparse; print urlparse.urlsplit('http://www.famfamfam.com](http://www.famfamfam.com/', 'http', True)" SplitResult(scheme='http', netloc='www.famfamfam.com](http:', path='//www.famfamfam.com/', query='', fragment=