[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Éric Araujo added the comment: Patch committed in r83993 (py3k), r83994 (3.1) and r83996 (2.7). I got the version wrong in 3.x and fixed it in r83995 and r83998. -- ___ Python tracker _

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Éric Araujo added the comment: 2.6 regression reverted in r83992. Tarek is okay with my patch for the other branches. I noticed the first fix did not have a versionadded in the docs, so I’ll add that and commit. -- assignee: tarek -> eric.araujo priority: release blocker -> high

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Barry A. Warsaw added the comment: This is a regression introduced in 2.6.6rc1. After discussion in irc with merwok, it is agreed that he will revert to pre-2.6.6rc1 behavior and not apply any fix. It's way too late to be changing behavior in 2.6.6. Folks using Python 2.6 will just have to

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Éric Araujo added the comment: New version of the patch to address Tarek’s comments and add NEWS and docs entries. -- ___ Python tracker ___

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Changes by Éric Araujo : Added file: http://bugs.python.org/file18517/sdist-manifest-marker.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Changes by Éric Araujo : Removed file: http://bugs.python.org/file18482/sdist-manifest-marker.diff ___ Python tracker ___ ___ Python-bugs-list

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Éric Araujo added the comment: Attaching a patch to implement the marker idea. No doc changes yet. It should work transparently: you don’t have to give an option to have automatic recalculation, you don’t have to give an option to have it leave your manual MANIFEST alone. (For the curious, h

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Tarek Ziadé added the comment: I like the idea of a marker in a comment line in the MANIFEST, we can introduce this as a bug fix to avoid this regression -- ___ Python tracker _

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Ronald Oussoren added the comment: I agree with msg113530 and msg112371 that the current behavior is a bug: distutils is now too agressive because it recalculates the MANIFEST file even when distutils isn't the one that calculated it in the first place. This is a functional regression w.r.t.

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

J. David Ibáñez added the comment: This issue has broken our build system too. A bug has been fixed, but another one is open now. If the MANIFEST file has been produced by distutils it should be regenerated each time. But if it has not been produced by distutils then it should not regenerated

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Changes by Dirkjan Ochtman : -- nosy: +djc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Tarek Ziadé added the comment: Follow-up at http://selenic.com/pipermail/mercurial-packaging/2010-August/09.html -- ___ Python tracker ___ __

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Matt Mackall added the comment: Ok, we need a change that will work with Python 2.4 through 2.7. -- ___ Python tracker ___ ___ Python-

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Tarek Ziadé added the comment: this fix was done to avoid generating broken MANIFEST file with sdist. IIUC your problem is more about avoiding generating a MANIFEST file at *all* via sdist, so we should add a --no-manifest option to the sdist command. This can be added today in Mercurial setu

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Matt Mackall added the comment: This change just wrecked Mercurial's release build process. We've been building Mercurial release tarballs with a Makefile target wrapped around sdist for most of five years, and we've never had or wanted a MANIFEST.in file. We generate an exact, complete, and

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Tarek Ziadé added the comment: done in r81255, r81256 (2.6), r81258 (py3), r81260 (3.1) Thanks Ronald -- status: open -> closed ___ Python tracker ___ __

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Changes by Tarek Ziadé : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Tarek Ziadé added the comment: The same problem occurs without a manifest template: you can have options or imports in setup.py that will change the MANIFEST file. For example : if setup() has: packages=['foo'] And if you add a subpackage "bar" in "foo" with some modules, with an existing

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Ronald Oussoren added the comment: One way to fix this: is to always recreate MANIFEST when an explicit MANIFEST.in file exists, as in the attached patch. (The patch is not perfect: I'd rename "template_newer" before committing) -- keywords: +needs review, patch Added file: http://bug

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

Changes by Dan Buch : -- nosy: +meatballhat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

New submission from Ronald Oussoren : The sdist command in distutils calculates the MANIFEST file from a template (by default MANIFEST.in). The code in sdist assumes that the contents of MANIFEST only depends on MANIFEST.in and setup.py, which can cause files to be missed when building an sd