[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Antoine Pitrou added the comment: I've committed a patch which unconditionally skips those tests in 2.6 (r80867) and 3.1 (r80868). Thanks for your advice. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Antoine Pitrou added the comment: > I don't think the test actually achieves that, as we are testing against > our own implementation (IIUC). To be sure that this really triggers the > right bytes on the wire, we would have to test against an independent > TLS implementation. Yes, it's a best e

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Martin v. Löwis added the comment: > I agree that these tests are more integration tests than unit tests; > however, they are useful in exercising the code and options we provide > (otherwise we wouldn't know whether e.g. PROTOCOL_TLSv1 really does what > it claims to do). I don't think the tes

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Antoine Pitrou added the comment: > Notice that we should *not* test OpenSSL - hopefully, they have their > own test suites. Instead, we should only test the Python integration of > OpenSSL. Therefore, we should only write test cases that work > independent of the OpenSSL version (except when so

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Martin v. Löwis added the comment: > OpenSSL 1.0.0 disables SSLv2 by default, which means the protocol > combination tests give different results (for example, an SSLv23 client > will refuse talking to an SSLv2 server, because the client will attempt > an SSLv3 hello). I see. I think we should

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Antoine Pitrou added the comment: > I don't think we should use the openssl binary for anything. It may > belong to a different version, and it may not be available (in > particular on Windows). Agreed. > I don't understand the problem you are trying to solve. What exactly > is it that will st

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Martin v. Löwis added the comment: I don't think we should use the openssl binary for anything. It may belong to a different version, and it may not be available (in particular on Windows). I don't understand the problem you are trying to solve. What exactly is it that will stop working on Op

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue8629] Fix test_ssl failures under 2.6/3.1 with OpenSSL 1.0.0

New submission from Antoine Pitrou : OpenSSL 1.0.0 needs to change the cipher list for some test_ssl tests to succeed, but the cipher list can't be changed in 2.6/3.1 (maintenance branches). The solution is to skip these tests with the newer OpenSSLs. This patch uses the "openssl" executable t