[issue8620] wrong truncation of last line in cmd.Cmd

Mattelaer added the comment: Thanks a lot for the fix. On 02-août-10, at 01:58, R. David Murray wrote: > > R. David Murray added the comment: > > Thanks, Éric. Fixed. > > -- > > ___ > Python tracker > > ___

[issue8620] wrong truncation of last line in cmd.Cmd

R. David Murray added the comment: Thanks, Éric. Fixed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue8620] wrong truncation of last line in cmd.Cmd

Éric Araujo added the comment: If “l” sorts after “a”, you’ve misplaced Catherine in ACKS. Funny how often this happens :) (Cheers for the Teach Me session by the way Catherine!) -- ___ Python tracker ___

[issue8620] wrong truncation of last line in cmd.Cmd

Éric Araujo added the comment: Universal newline mode helps when reading from stdin, but what I had in mind was actually in cmd.exe putting CRLF. Re-reading the original report, I see this is not a concern, since the bug is about cmd used with a file only, not interactively, so my remark was

[issue8620] wrong truncation of last line in cmd.Cmd

R. David Murray added the comment: Éric: thanks for spotting the whitespace before I got smacked by the commit hook. As for \r\n, our thought was that would be a feature (universal newline support), but upon reflection the current fix could actually break working code if by some weird chance

[issue8620] wrong truncation of last line in cmd.Cmd

Catherine Devlin added the comment: same patch, stripped of trailing spaces -- Added file: http://bugs.python.org/file18297/cmd-noeol-test.fix.patch ___ Python tracker ___ __

[issue8620] wrong truncation of last line in cmd.Cmd

Éric Araujo added the comment: Sorry, RDM is the actual culprit ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue8620] wrong truncation of last line in cmd.Cmd

Éric Araujo added the comment: Test runs okay on posix (linux2). Does the fix need to work with '\r\n' too? Aside: Your patch has trailing spaces, you can spot them with good editor settings. -- ___ Python tracker

[issue8620] wrong truncation of last line in cmd.Cmd

Catherine Devlin added the comment: Patch created live during PyOhio 2010 "Teach Me Python Bugfixing" session! -- nosy: +catherine Added file: http://bugs.python.org/file18294/cmd-noeol-test.fix.patch ___ Python tracker

[issue8620] wrong truncation of last line in cmd.Cmd

R. David Murray added the comment: Here is a unit test that demonstrates the problem (against py3k trunk). I'm not convinced that fixing this would be backward incompatible. -- ___ Python tracker

[issue8620] wrong truncation of last line in cmd.Cmd

Changes by R. David Murray : -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/o

[issue8620] wrong truncation of last line in cmd.Cmd

Changes by R. David Murray : Added file: http://bugs.python.org/file18281/cmd-noeol-test.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue8620] wrong truncation of last line in cmd.Cmd

Changes by R. David Murray : Removed file: http://bugs.python.org/file18280/cmd-noeol-test.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue8620] wrong truncation of last line in cmd.Cmd

R. David Murray added the comment: Here is a unit test that demonstrates the problem (against py3k trunk). I'm not convinced that fixing this would be backward incompatible. (NB: please no one patch this bug, I'm expecting the patch to get created tomorrow during PyOhio.) -- keywo

[issue8620] wrong truncation of last line in cmd.Cmd

Éric Araujo added the comment: Setting version to 3.2, since this change would not be backward compatible and 2.7 is already in beta. -- components: +Library (Lib) -None nosy: +merwok title: wrong truncation of line in Cmd.cmd -> wrong truncation of last line in cmd.Cmd versions: +Pyt