[issue8594] Add a "source_address" option to ftplib

Changes by Giampaolo Rodola' : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue8594] Add a "source_address" option to ftplib

Roundup Robot added the comment: New changeset 7f605fa1688d by Giampaolo Rodol�� in branch 'default': #8594: fix ResourceWarning in test_ftplib.py - patch by Nadeem Vawda. http://hg.python.org/cpython/rev/7f605fa1688d -- nosy: +python-dev ___ Python

[issue8594] Add a "source_address" option to ftplib

Nadeem Vawda added the comment: I'm not seeing the commit anywhere. Did you perhaps forget to "hg push" after committing? -- ___ Python tracker ___ _

[issue8594] Add a "source_address" option to ftplib

Giampaolo Rodola' added the comment: Ok, that wasn't r68309. =) I'm not sure what revision number is now that we're using mercurial. -- ___ Python tracker ___ ___

[issue8594] Add a "source_address" option to ftplib

Giampaolo Rodola' added the comment: Committed in r68309. -- status: pending -> open ___ Python tracker ___ ___ Python-bugs-list maili

[issue8594] Add a "source_address" option to ftplib

Antoine Pitrou added the comment: Giampaolo, can you make your commit on the Mercurial repo instead? See http://mail.python.org/pipermail/python-dev/2011-March/108738.html -- status: closed -> pending ___ Python tracker

[issue8594] Add a "source_address" option to ftplib

Giampaolo Rodola' added the comment: Thanks. Committed in r88761. -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-

[issue8594] Add a "source_address" option to ftplib

Changes by Antoine Pitrou : -- status: closed -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue8594] Add a "source_address" option to ftplib

Nadeem Vawda added the comment: test_source_address_passive_connection() raises a ResourceWarning. Fix attached. -- nosy: +nvawda Added file: http://bugs.python.org/file21019/test_ftplib-leak.diff ___ Python tracker

[issue8594] Add a "source_address" option to ftplib

Changes by Giampaolo Rodola' : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8594] Add a "source_address" option to ftplib

Giampaolo Rodola' added the comment: Committed in r88679. -- versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-

[issue8594] Add a "source_address" option to ftplib

Giampaolo Rodola' added the comment: Patch in attachment set source_address attribute and updates doc. It still keeps using support.find_unused_port() which is also used in test_socket.py though [1], so it shouldn't cause problems. http://svn.python.org/view/python/trunk/Lib/test/test_socket.p

[issue8594] Add a "source_address" option to ftplib

Changes by Antoine Pitrou : -- assignee: -> giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue8594] Add a "source_address" option to ftplib

Giampaolo Rodola' added the comment: > You should not use find_unused_port() I agree find_unused_port() is the wrong approach in general, but in this case I think there's nothing we can do about it. > you never set self.source_address. You're right, I should set it in connect() method. I'm g

[issue8594] Add a "source_address" option to ftplib

Antoine Pitrou added the comment: You should not use find_unused_port(), because it causes problems on some Windows buildbot. Also, there's something fishy in your patch, because you never set self.source_address. -- ___ Python tracker

[issue8594] Add a "source_address" option to ftplib

New submission from Giampaolo Rodola' : Similarly to issue 3972 the patch in attachment adds a new "source_address" option to FTP class to bind to a specific address when connecting to a remote FTP server. It must be noted that this gets done for both control and passive data connections (cli