[issue8591] update mkpkg to latest coding standards

Changes by Éric Araujo : -- resolution: accepted -> out of date stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: > Changing “if s in 'yn'” to “if s in ('y', 'n')” is not really an > improvement. It’s not more readable to always use tuples or frozensets > for membership testing; str has __contains__ for a reason :) Let me eat my words: using “in 'yn'” matches '' and 'yn', whi

[issue8591] update mkpkg to latest coding standards

Changes by Michael Mulich : -- nosy: +michael.mulich ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: FYI, the mkcfg module has seen a lot of change since last summer, some of which have bad style. I still have this bug on my todo list to fix that. -- ___ Python tracker

[issue8591] update mkpkg to latest coding standards

Changes by Sean Reifschneider : -- nosy: -jafo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue8591] update mkpkg to latest coding standards

Changes by Éric Araujo : -- versions: +3rd party -Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: After speaking with a Montreal-Python hacker about my use case and reading the PyMOTW page for cmd, I think that using raw_input and print is actually the way to go. We don’t want the user to enter commands, just to answer questions. --

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: I have six changesets that make progressive improvements on cosmetic things, so that the code gets more readable. You can start with http://bitbucket.org/Merwok/distutils2-killsetup/changeset/5e2906cabeab and follow the parent links. The other changes you made

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: I’m assigning this bug to myself as part of my work on #8252. Dan, I’ll sort the various fixes in your patch and replay them incrementally. I’ll be pleased to work with you if you have time (find me in #distutils or through email), if you don’t thanks for the st

[issue8591] update mkpkg to latest coding standards

Dan Buch added the comment: @merwok much thanks for the feedback. After seeing how you're working via bitbucket I've decided to create a fresh fork from tarek and recreate my patch in multiple changesets all within the default branch. I'll update the issue when finished. -- __

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: I’ve started to review your patch but I find it a bid unwieldy to read. Would you mind exporting changesets to patches? I tried to look at your repo, but didn’t know which branch to look at. So, thanks for giving us the occasion of thinking about the patch workf

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : Added file: http://bugs.python.org/file17408/mkpkg-round-of-pylinting.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : Removed file: http://bugs.python.org/file17407/mkpkg-round-of-pylinting.patch ___ Python tracker ___ ___ Python-bugs-list

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : Removed file: http://bugs.python.org/file17406/mkpkg-round-of-pylinting.patch ___ Python tracker ___ ___ Python-bugs-list

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : Added file: http://bugs.python.org/file17407/mkpkg-round-of-pylinting.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : Added file: http://bugs.python.org/file17406/mkpkg-round-of-pylinting.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : Removed file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch ___ Python tracker ___ ___ Python-bugs-list

[issue8591] update mkpkg to latest coding standards

Dan Buch added the comment: The attached mkpkg-round-of-pylinting.patch is known to cleanly apply to tarek's branch @ 541f90ef0636 -- ___ Python tracker ___

[issue8591] update mkpkg to latest coding standards

Changes by Dan Buch : -- keywords: +patch Added file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch ___ Python tracker ___ __

[issue8591] update mkpkg to latest coding standards

Dan Buch added the comment: I've started work on cleanup of ``mkpkg.py`` per instruction from jafo, am pushing to a branch 'mbh/mkpkg-cleanup' of my distutils2 fork: http://bitbucket.org/meatballhat/distutils2/changeset/be40174c59e2 I'll attach patch(es) when finished :) --

[issue8591] update mkpkg to latest coding standards

Tarek Ziadé added the comment: I am adding Sean (jafo) who wrote this module. He'll have the best answer :) -- nosy: +jafo ___ Python tracker ___

[issue8591] update mkpkg to latest coding standards

Dan Buch added the comment: bump. Would it be more helpful if I were to submit a patch, too, or is doing so prior to guidance from the driver (Tarek) frowned upon? -- ___ Python tracker __

[issue8591] update mkpkg to latest coding standards

Dan Buch added the comment: I probably shouldn't have dropped the PEP8 bomb so much as stated that I feel the module could use some updating. It's my (very much potentially wrong) understanding that `distutils2.mkpkg` isn't considered library code so much as the guts of a script. The reas

[issue8591] update mkpkg to latest coding standards

Éric Araujo added the comment: Pepeightification is ok for things like whitespace that do not break compatibility (don’t waste time doing it manually though, we have automated tools that can be used to reindent the whole of Distutils2). However, renaming classes and functions has to be done w

[issue8591] update mkpkg to latest coding standards

New submission from Dan Buch : On first glance, `distutils2.mkpkg` does not reflect the latest and greatest in Python coding standards. I'd like to take a stab at PEP-(7|8)'ing the whole thing, although I know there are other issues open to add features to the module, so I don't want to cause