[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: Close this issue: nothing special on the buildbots. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue850997] mbcs encoding ignores errors

Tim Golden added the comment: I'm unlikely to get to it soon. If there's no urgency I can look at it later. FWIW, it's not something I'm especially familiar with. On 12/06/2010 01:02, STINNER Victor wrote: > > STINNER Victor added the comment: > > Tim: are you interested in testing this patch?

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: I commited the last patch to py3k: r82037. Let see how the buildbots react :-) -- ___ Python tracker ___ _

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: Patch version 4: - encode_mbcs() uses WC_NO_BEST_FIT_CHARS flag in strict mode. Examples: ğ and ł are not more replaced by g and l - encode_mbcs() doesn't set *repr to NULL on encode error: the caller does anyway destroy it - write more documentation about

[issue850997] mbcs encoding ignores errors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file17622/mbcs_errors-py3k-2.patch ___ Python tracker ___ ___ Python-bugs-li

[issue850997] mbcs encoding ignores errors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file17456/mbcs_errors-py3k.patch ___ Python tracker ___ ___ Python-bugs-list

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: Update the patch (I commited the patch on tarfile module): version 3. -- Added file: http://bugs.python.org/file17635/mbcs_errors-py3k-3.patch ___ Python tracker

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: Tim: are you interested in testing this patch? -- nosy: +tim.golden ___ Python tracker ___ ___ Pyt

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: New version of the patch: - decode_mbcs() calls raise_translate_exception() to set the error (in the previous patch, I'm not sure that the error was set) - include #8784 patch (tarfile uses utf-8 as the default encoding) - ctypes: use mbcs is strict mode ins

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: I worked again on the patch. I opened new issues to prepare the new mbcs codec: - #8966: ctypes: remove implicit conversion between unicode and bytes - #8967: Create PyErr_GetWindowsMessage() function - #8969: Windows: use (mbcs in) strict mode to encode/deco

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: Updated version of the patch for py3k: - don't accept "ignore" error handler anymore - there is a FIXME near "mbcs_decode_error:" The whole test suite pass with these patch. -- Added file: http://bugs.python.org/file17456/mbcs_errors-py3k.patch

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: Since this change breaks backward compatibility, it's a very bad idea to change mbcs codec in Python 2.7: remove this version from this issue. -- versions: -Python 2.7 ___ Python tracker

[issue850997] mbcs encoding ignores errors

STINNER Victor added the comment: I patched py3k with mbcs_errors.patch (only encode_mbcs, not the decoder function) and most test pass: I opened #8784 for test_tarfile failure. I don't think that it's a problem that mbcs only supports few error handlers, eg. 'strict', 'replace' and 'errors'

[issue850997] mbcs encoding ignores errors

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue850997] mbcs encoding ignores errors

Changes by Ezio Melotti : -- nosy: +ezio.melotti versions: +Python 2.7, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue850997] mbcs encoding ignores errors

Mark Hammond added the comment: It is still present, but I'm not sure what problems can be seen due to this so can't comment on its desirability. It would also introduce a backwards compatability concern but I've not enough experience to know how much of a problem that would be in practice eith

[issue850997] mbcs encoding ignores errors

Changes by Thomas Heller : -- nosy: -theller ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue850997] mbcs encoding ignores errors

Daniel Diniz added the comment: Is this behavior still present? If so, is it still interesting to change it? -- components: +Unicode keywords: +patch nosy: +ajaksu2 stage: -> test needed type: -> feature request ___ Python tracker