[issue8464] tarfile creates tarballs with execute permissions set

Lars Gustäbel added the comment: I applied the patch and added a test case (see r80616-r80619). Thanks for the report. -- resolution: -> accepted stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue8464] tarfile creates tarballs with execute permissions set

Lars Gustäbel added the comment: 0666 is the right mode and the patch is correct. @Tarek: Why does shutil.make_archive() use mode "w|..." instead of "w:..."? IMHO that is not necessary, because it works on regular files only. -- ___ Python tracker

[issue8464] tarfile creates tarballs with execute permissions set

Changes by Tarek Ziadé : -- assignee: -> lars.gustaebel nosy: +lars.gustaebel ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8464] tarfile creates tarballs with execute permissions set

Lino Mastrodomenico added the comment: I think 0666 is correct because os.open() does a bitwise AND between this value and the bitwise inversion of the umask, something like oct(0666 & ~umask). Since the umask is usually 022 octal (18 decimal), the actual permission on disk should be 0644 as

[issue8464] tarfile creates tarballs with execute permissions set

Changes by Shashwat Anand : -- nosy: +tarek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue8464] tarfile creates tarballs with execute permissions set

Shashwat Anand added the comment: Is "self.fd = os.open(name, mode, 0666)" Ok ? Should not it be "self.fd = os.open(name, mode, 0644)", because that is what the default permissions are. -- nosy: +l0nwlf ___ Python tracker

[issue8464] tarfile creates tarballs with execute permissions set

New submission from Lino Mastrodomenico : tarfile.open(filename, "w|") creates a tar file with execute permissions set, if filename doesn't exist (i.e. it uses mode 0777 minus the umask). It should instead use mode 0666 minus the umask, which is what happens when using mode "w:..." instead of