[issue8414] Add test cases for assert

Ezio Melotti added the comment: Committed, thanks for the patch! I preferred to add a separate test, because only the tests with "assert False" need to be skipped with -O, the other can run with and without -O. -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review ->

[issue8414] Add test cases for assert

Roundup Robot added the comment: New changeset bcfb499338c1 by Ezio Melotti in branch '2.7': #8414: add more tests for "assert". Initial patch by Gregory Nofi. http://hg.python.org/cpython/rev/bcfb499338c1 New changeset 1efefeda00a7 by Ezio Melotti in branch '3.2': #8414: add more tests for "a

[issue8414] Add test cases for assert

Changes by Gregory Nofi : Added file: http://bugs.python.org/file17036/test_grammar.v3.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue8414] Add test cases for assert

Gregory Nofi added the comment: I've uploaded new versions of the patch. __debug__: I removed the "if __debug__" clause and switched to skipUnless. Exception args: I replaced str(e) with e.args. Thanks for pointing that out! I had thought args was going to be deprecated but I guess it's not (

[issue8414] Add test cases for assert

Ezio Melotti added the comment: Wouldn't it be better to test e.args instead or in addition to str(e)? Skipping the whole test if __debug__ is False is also a good idea. -- nosy: +ezio.melotti priority: -> normal stage: -> patch review ___ Python t

[issue8414] Add test cases for assert

Benjamin Peterson added the comment: I propose you move all the assert test cases into there own test method and decorate it with @unittest.skipUnless(__debug__). -- nosy: +benjamin.peterson ___ Python tracker ___

[issue8414] Add test cases for assert

Changes by Gregory Nofi : Added file: http://bugs.python.org/file16943/test_grammar.v3.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue8414] Add test cases for assert

New submission from Gregory Nofi : I'm adding some assert tests to test_grammar.py to verify that the assert statement raises (or doesn't raise) an AssertionError properly. NOTE: I'm currently helping Dino port IronPython tests into CPython. This is part of that series. -- components: