[issue8361] Remove assert in functools.total_ordering

2010-04-10 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue8361] Remove assert in functools.total_ordering

2010-04-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: r79930 and r79931 -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue8361] Remove assert in functools.total_ordering

2010-04-10 Thread Éric Araujo
Éric Araujo added the comment: Ok. It won’t have a user-friendly error message, though. You may be interested in a minor doc patch in #5341. Regards -- ___ Python tracker ___ _

[issue8361] Remove assert in functools.total_ordering

2010-04-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: The max(roots) line that follows will raise its own ValueError when given an empty input. Will mull over your patch. I may just delete the assert line, leave it as-is, or apply something like your patch (but with a ValueError). -- _

[issue8361] Remove assert in functools.total_ordering

2010-04-10 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue8361] Remove assert in functools.total_ordering

2010-04-10 Thread Éric Araujo
New submission from Éric Araujo : Hello The correct behavior of functools.total_ordering depends on a check performed with an assert. Attached patch changes it to a test that always runs. Since it’s a kind of protocol error, I went for TypeError but you may disagree. Regards -- compo