[issue8232] webbrowser.open incomplete on Windows

Eryk Sun added the comment: Windows Vista is no longer a concern, so find_windows_browsers() doesn't have to worry about the KEY_WOW64_* flags. IMO, it should get the browser's real name (the default value of the key) and the fully-qualified path of the executable, instead of depending solel

[issue8232] webbrowser.open incomplete on Windows

Change by Eryk Sun : -- components: +Windows dependencies: +[Windows] support args and cwd in os.startfile() nosy: +paul.moore, tim.golden, zach.ware versions: +Python 3.10 -Python 3.6 ___ Python tracker _

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: I have Windows 10, 64-bit, and Python 3.6.1, 64-bit, and the code still does not work! >>> import webbrowser >>> webbrowser.get("chrome") Traceback (most recent call last): File "", line 1, in File "C:\Program Files\Python 3.6\lib\webbrowser.py", line 51, i

[issue8232] webbrowser.open incomplete on Windows

Mariatta Wijaya added the comment: Steve, would you like to create a PR based on your patch here? Also, what versions should this be targeted to now? Thanks. -- nosy: +Mariatta ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Changes by Carol Willing : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I've tested the new patch and it is still able to properly find both chrome and firefox and is able to differentiate between new window and new tab for those two browsers so it is still working. Would someone review the patch? -- __

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Finally got it rebuilt after having trouble with visual studio for awhile. I've tested the new patch and it is still able to properly find both chrome and firefox and is able to differentiate between new window and new tab for those two browsers so it appears t

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: The C part of the patch adds an extra argument to startfile to accept the arguments. You'll need to rebuild Python to test the change completely - it's no longer just a pure Python change. -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Ok I've been able to test the new patch now and I'm not sure that os.startfile is going to work. I've been able to get os.startfile() to open a specified browser (>>> os.startfile("chrome.exe", "open")), however, the function does not allow additional arguments

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: New patch against 3.6. -- Added file: http://bugs.python.org/file40393/8232_1.patch ___ Python tracker ___ _

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: Try doing: hg up -r 4e329892817c1eed81aafd14e82b8ef23b45a6e6 hg import --no-commit http://bugs.python.org/file40384/25005_1.patch That *should* apply it where I originally made it from. I'll do the same and rebase the patch against tip. -- _

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: applying 25005_1.patch patching file Lib/webbrowser.py Hunk #1 FAILED at 498 Hunk #2 FAILED at 524 Hunk #3 FAILED at 532 Hunk #4 FAILED at 540 Hunk #5 FAILED at 548 I'm trying to apply your patch after applying webbrowserfix6.patch but I am encountering problems.

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: Here's an alternate patch I proposed on #25005 before we decided to back out the change. The problem is that subprocess.call() with shell=True is unsafe because we don't escape shell operators (such as &, <, >, |). The fix in this patch is to allow passing argum

[issue8232] webbrowser.open incomplete on Windows

Roundup Robot added the comment: New changeset aa60b34d5200 by Steve Dower in branch '3.5': Issue #25005: Backout fix for #8232 because of use of unsafe subprocess.call(shell=True) https://hg.python.org/cpython/rev/aa60b34d5200 New changeset 7d320c3bf9c6 by Larry Hastings in branch '3.5': Merge

[issue8232] webbrowser.open incomplete on Windows

Larry Hastings added the comment: This was backed out of 3.5, as we discovered it introduced a security hole just before 3.5.0 shipped. (See issue 25005 for more.) Since it's been backed out, I've reopened the issue. However I've moved it forward to 3.6, as it's no longer viable to accept fo

[issue8232] webbrowser.open incomplete on Windows

Changes by Larry Hastings : -- nosy: -larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: No need to answer. Python used the webbrowser module that was located in the directory of my application and not the one from the interpreter's directory. That's great! -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: Ah, interesting! But which webbrowser module would Python import if I have one webbrowser.py in my interpreter's directory and one webbrowser.py in the directory of my application? -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: Sure, you can do that. You can also copy-paste it into your project to get the same effect. -- ___ Python tracker ___ _

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: Steve, I know. But it's a hassle for a newcomer to fix Python first before he/she uses it. I'm not a newcomer, but even I don't know how to fix webbrowser.py, more specifically the webbrowser.get() method, to be able to use it. Maybe I should copy webbrowser.

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: Fairly sure webbrowser.py is stand-alone enough that you could redist it with your package easily enough. None of the rest of the stdlib should depend on the internals, AFAIK. -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: I understand. But then webbrowser.get("chrome") won't ever work in Python 3.4. Is there no other way to fix this bug in Python 3.4 without adding the new feature? -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Larry Hastings added the comment: Yes, which is why I permitted a feature freeze exception for it for 3.5. But it's simply far, far too late to add a feature like this to 3.4. -- ___ Python tracker ___

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: I understand. I know that Python 3.4 is way past feature freeze. But if we document the new stuff in the documentation, saying "Added to Python 3.4.4", people would know about and be able to use the new stuff. And we won't break people's code. In fact, people m

[issue8232] webbrowser.open incomplete on Windows

Larry Hastings added the comment: Rules like this are there for a reason. People rely on Python being consistent. We've added harmless new features to point releases in the past and broken people's code. So, we don't do it anymore. It's not because we don't care, it's because stability is m

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: Sure, let's have a broken feature in Python 3.4, who cares. -- ___ Python tracker ___ ___ Python-bugs-

[issue8232] webbrowser.open incomplete on Windows

Larry Hastings added the comment: This is not a bugfix to existing code. This is new code to implement a missing feature. -- ___ Python tracker ___ _

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: No, Larry, this is not a new feature. The feature, as it stands, is broken in Python 3.4, so we need to fix it. -- ___ Python tracker ___ ___

[issue8232] webbrowser.open incomplete on Windows

Larry Hastings added the comment: Sorry, but I think this is more accurately described as a "new feature" than a "bugfix". Please don't backport this to 3.4. -- ___ Python tracker _

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: The 3.4 RM is already nosied - what say you, sir? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: Now that this bug is completely fixed, can you backport this to the '3.4' branch, so that we'll be able to use webbrowser. get() in Python 3.4.4 when it becomes available? -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: I'll close this as fixed, but feel free to speak up if you spot anything else that needs fixing. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Roundup Robot added the comment: New changeset 0d54a78861cf by Steve Dower in branch '3.5': Issue #8232: Renamed WinFireFox to WinFirefox https://hg.python.org/cpython/rev/0d54a78861cf New changeset 8667c26e2bec by Steve Dower in branch 'default': Issue #8232: Renamed WinFireFox to WinFirefox ht

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: That's what I thought, but I wasn't 100% sure it wasn't moved/rewritten in the patch and was on my phone so I didn't check :) -- ___ Python tracker ___

[issue8232] webbrowser.open incomplete on Windows

Arfrever Frehtes Taifersar Arahesis added the comment: Steve Dower: Maybe thou hast already forgotten, but WinFireFox class was added by thee (only in 3.5 and 3.6) just 7 days ago :) . -- ___ Python tracker ___

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: If it existed in 3.4 then we can only alias it now and not fix it. 3.5 and 3.6 can have the fix. -- ___ Python tracker ___

[issue8232] webbrowser.open incomplete on Windows

Boštjan Mejak added the comment: I agree with Arfrever Frehtes Taifersar Arahesis (oh my god, you have the longest name, dude!) to rename the class WinFireFox() to WinFirefox(). Okay, so since the branch '3.5' already got its patch webbrowserfix6 applied -- are you, Brandon Milam, willing to m

[issue8232] webbrowser.open incomplete on Windows

Arfrever Frehtes Taifersar Arahesis added the comment: Official spelling of name of one of these browsers is "Firefox", not "FireFox". I suggest to rename WinFireFox class accordingly. -- nosy: +Arfrever ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Roundup Robot added the comment: New changeset b75c600e1614 by Steve Dower in branch '3.5': Issue #8232: webbrowser support incomplete on Windows. Patch by Brandon Milam https://hg.python.org/cpython/rev/b75c600e1614 New changeset 63b6e150b635 by Steve Dower in branch 'default': Issue #8232: web

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: That looks good to me, I'll get it merged in when I'm at my desk. -- ___ Python tracker ___ ___ Python-b

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Moved the 64 bit browser list to its own loop and switched to browsers.append rather than +=. -- Added file: http://bugs.python.org/file39650/webbrowserfix6.patch ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Larry Hastings added the comment: Go ahead for beta 3. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Here's a patch addressing all of the comments in the review. Changing the browsers from a set to a list though resulted in duplicates in the _tryorder list that were not present before because the set had filtered the duplicates before the partial string compar

[issue8232] webbrowser.open incomplete on Windows

R. David Murray added the comment: I haven't reviewed the patch, but if it only makes the existing API actually work for Windows, I think it would be fair game for 3.5. Larry would need to make the call, though. -- nosy: +larry, r.david.murray ___

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: I do like this fix, and I'm sorry I didn't get to reviewing it before beta 1 was released - can we consider this something to fix for 3.5 or do we need to slip it until 3.6? -- ___ Python tracker

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Forgive me the excessive number of patch submissions as I am still getting my feet wet in contributing to Python. I'm posting another patch that is not functionally different from the last patch but should better adhere to the PEP8 style guide. Please let me k

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: On second thought no type testing is required if sets are used because the union will take out duplicates anyways and so I removed the type testing and left in the set union code. -- Added file: http://bugs.python.org/file39534/webbrowserfix3.patch ___

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I went ahead and took the assert statement out and added support for vista using a union of sets for both the 32 bit and 64 bit locations. -- Added file: http://bugs.python.org/file39533/webbrowserfix3.patch ___ Pytho

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I kept the changes to the WindowsDefault.open() method and used and extended eryksun's code to build the browser list using the registry. Also I added support for a few more browsers. Some of the browsers I could not find ways to differentiate between opening a

[issue8232] webbrowser.open incomplete on Windows

eryksun added the comment: > register themselves in HKEY_LOCAL_MACHINE\SOFTWARE\ > Clients\StartMenuInternet so that users can change their > default browser through the OS. On 64-bit systems, this > is always in the 64-bit registry According to "Registry Keys Affected by WOW64", the "Clients"

[issue8232] webbrowser.open incomplete on Windows

Steve Dower added the comment: Some hints about finding browsers on Windows. When browsers are installed, they should register themselves in HKEY_LOCAL_MACHINE\SOFTWARE\Clients\StartMenuInternet so that users can change their default browser through the OS. On 64-bit systems, this is always i

[issue8232] webbrowser.open incomplete on Windows

Changes by Zachary Ware : -- stage: needs patch -> patch review versions: +Python 3.5 -Python 3.1 ___ Python tracker ___ ___ Python-bug

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I got rid of the __init__ for the WindowsDefault class that I asked about earlier and changed it to match the sub-classing model that the Unix browsers use. This caused some changes in the get function too. Due to the _isexecutable still not completely working,

[issue8232] webbrowser.open incomplete on Windows

Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: How the _isexecutable function is set up now it would require a full path name in order to be able to tell if a specific browser is on the system. The area under platform support for windows checks for multiple browsers using this function but only passes it br

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: In order to fix the issue I added on to the WindowsDefault class so that it is the main browser class for windows platforms as opposed to being a default when no other browser is given. I gave the class an init where it specifies specific flags for firefox, chr

[issue8232] webbrowser.open incomplete on Windows

Dev Player added the comment: Don't forget to check if the MS Internet Explorer's advanced option to open new URLS in a seperate windows effects this. Users can have this advanced setting set differently on different computers(or even accounts). Also different browser versions call that opti

[issue8232] webbrowser.open incomplete on Windows

Brian Curtin added the comment: Minor correction: BackgroundBrowser gets used in this case, but it still lacks in the same area and causes what you are seeing. -- ___ Python tracker ___

[issue8232] webbrowser.open incomplete on Windows

Changes by Brian Curtin : -- title: webbrowser open(), open_new(), and open_new_tab() Broken Functionality -> webbrowser.open incomplete on Windows ___ Python tracker ___ ___