[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-30 Thread Marc-Andre Lemburg
gt; regression. See the new implementation for what I meant... r80665 - in python/trunk: configure configure.in r80666 - in python/branches/py3k: configure configure.in [issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS Only override the AC_PROG_CC determined CFLAGS if they were set by the use

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-30 Thread STINNER Victor
STINNER Victor added the comment: Sorry but i don't really understand the problem of my patch, and I don't want to spend time of this. Revert my patch if you think that it introduced a regression. -- ___ Python tracker

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Marc-Andre Lemburg wrote: > > Marc-Andre Lemburg added the comment: > > Please change the configure.in script to only override the CFLAGS in case > they were set before entering the AC_PROG_CC part ! Sorry, this should have read: ... if CFLAGS *were* s

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: > STINNER Victor added the comment: > > Even if this issue doesn't fix all the configure "complete mess", I think > that it improves it a little bit. Open new issues if you would like to fix > other parts of the configure script. Viktor, you are still m

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-22 Thread STINNER Victor
STINNER Victor added the comment: Even if this issue doesn't fix all the configure "complete mess", I think that it improves it a little bit. Open new issues if you would like to fix other parts of the configure script. -- resolution: -> fixed status: open -> closed

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-22 Thread Ned Deily
Ned Deily added the comment: I think the issue can be closed again. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-22 Thread STINNER Victor
STINNER Victor added the comment: Issue #8366 was caused by a fix of issue #1628484 (and ok, indirectly by my change). Issue #8366 is now fixed. Can I close this issue again or do you think that there is still something to do? -- ___ Python tracker

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-11 Thread Ned Deily
Ned Deily added the comment: To be totally fair, it is likely that part of the OS X breakage was caused by the original code inadvertently working around the original CFLAGS misbehavior. From an OS X perspective, it may be best to just fix the new issue and move on. -- __

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-11 Thread Marc-Andre Lemburg
Changes by Marc-Andre Lemburg : -- resolution: fixed -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Reopening the ticket: it shouldn't have been closed. I'm also making this a release blocker, since this needs to be fixed before the next release - the CC variable has to be initialized by the build system and breaking this in general for all default buil

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Victor, could you please fix the patch or revert it ? Thanks. -- ___ Python tracker ___ ___ Pyt

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-04-10 Thread Ned Deily
Ned Deily added the comment: Note these changes to restore CFLAGS have the side effect of breaking OS X universal builds; see Issue8366. -- nosy: +ned.deily ___ Python tracker _

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-25 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > > MaL> The patch you checked in still unconditionally overrides the > MaL> CFLAGS setting applied by AC_PROG_CC in case no CFLAGS variable > MaL> is set. > MaL> > MaL> The issue now is: AC_PROG

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-25 Thread STINNER Victor
STINNER Victor added the comment: MaL> The patch you checked in still unconditionally overrides the MaL> CFLAGS setting applied by AC_PROG_CC in case no CFLAGS variable MaL> is set. MaL> MaL> The issue now is: AC_PROG_CC no longer initializes CFLAGS MaL> if not set. Sorry, but I don't understa

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-25 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > >> I commited my patch: r79392 (trunk). I'm waiting for the buildbots before >> porting to other branches :-) > > The buildbots look happy => r79401 (py3k), blocked in 2.6 and 3.1 > > The is

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-25 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > > MaL> It unconditionally overrides CFLAGS - even if it is not > MaL> set and defined by AC_PROG_CC as "-g -O2". That would need > MaL> to be corrected. > MaL> > MaL> Other than that it does

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-24 Thread STINNER Victor
STINNER Victor added the comment: > I commited my patch: r79392 (trunk). I'm waiting for the buildbots before > porting to other branches :-) The buildbots look happy => r79401 (py3k), blocked in 2.6 and 3.1 The issue title was "configure: ignore AC_PROG_CC hardcoded CFLAGS", and not "fix co

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-24 Thread STINNER Victor
STINNER Victor added the comment: MaL> It unconditionally overrides CFLAGS - even if it is not MaL> set and defined by AC_PROG_CC as "-g -O2". That would need MaL> to be corrected. MaL> MaL> Other than that it does help a little work around the mess :-) I commited my patch: r79392 (trunk). I'

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > >> (or to fix it, but that's a major task - the whole CFLAGS >> and LDFLAGS system used in Python's configure has over the >> years turned into a complete mess). > > What do you mean by "a co

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-23 Thread STINNER Victor
STINNER Victor added the comment: > (or to fix it, but that's a major task - the whole CFLAGS > and LDFLAGS system used in Python's configure has over the > years turned into a complete mess). What do you mean by "a complete mess"? Did you try my patch? Is it enough to fix this issue? A leas

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-23 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Setting CFLAGS is broken in Python configure system, so it's better not to rely on it (or to fix it, but that's a major task - the whole CFLAGS and LDFLAGS system used in Python's configure has over the years turned into a complete mess). You should get

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +lemburg, loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue8211] configure: ignore AC_PROG_CC hardcoded CFLAGS

2010-03-23 Thread STINNER Victor
New submission from STINNER Victor : configure.in uses AC_PROG_CC, extract of the autoconf manual: (http://www.delorie.com/gnu/docs/autoconf/autoconf_64.html) If using the GNU C compiler, set shell variable GCC to `yes'. If output variable CFLAGS was not already set, set it to `-g -O2' for th