[issue8143] urlparse has a duplicate of urllib.unquote

R. David Murray added the comment: I synced the two versions in r81518 and added a comment to both about updating the other. -- resolution: -> wont fix stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue8143] urlparse has a duplicate of urllib.unquote

AdamN added the comment: I would vote to close this and focus any code cleanliness work on 3.x. The deep import is more trouble than it's worth. -- nosy: +adamnelson ___ Python tracker ___

[issue8143] urlparse has a duplicate of urllib.unquote

Brett Cannon added the comment: You could break it out into a module, but that feels like overkill for some minor code duplication that is not going to be a problem once we stop caring about Python 2.x. I personally wouldn't bother going that far. -- priority: normal -> low _

[issue8143] urlparse has a duplicate of urllib.unquote

Matt Giuca added the comment: What about the alternative (newmodule) patch? That doesn't have threading issues, or break backwards compatibility. -- ___ Python tracker ___ _

[issue8143] urlparse has a duplicate of urllib.unquote

Brett Cannon added the comment: So David's right that local commits are bad from a threading perspective. If you happen to have an import trigger a thread which itself triggers an import you will lock up the interpreter. Typically this is avoided by not importing anything in a thread and not

[issue8143] urlparse has a duplicate of urllib.unquote

Matt Giuca added the comment: If this patch is rejected, then at the very least, the urllib.unquote function needs a comment at the top explaining that it is duplicated in urlparse, so any changes should be made to both. Note that urlparse.unquote is not a documented function, or in the __all

[issue8143] urlparse has a duplicate of urllib.unquote

Senthil Kumaran added the comment: Yes, the reason for having the unquote verbatim was it created a circular reference otherwise. This was done when parse_qsl was moved from cgi module to the urlparse module. I would also like to know more on what RDM points out, tough I have seem some module

[issue8143] urlparse has a duplicate of urllib.unquote

R. David Murray added the comment: If I understand correctly, the problem with doing an import in a function is that there is an import lock which can cause various problem depending on how an application imports various things. I've added Brett to the nosy list to see if he has a definitive

[issue8143] urlparse has a duplicate of urllib.unquote

Changes by Ezio Melotti : -- nosy: +ezio.melotti priority: -> normal stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue8143] urlparse has a duplicate of urllib.unquote

New submission from Matt Giuca : urlparse contains a complete copy of the urllib.unquote function. This is extremely nasty code duplication -- I have two patches pending on urllib.unquote (#8135 and #8136) and I only just realised that I missed urlparse.unquote! The reason given for this is: