[issue8124] mywrite() ignores PyFile_WriteString() errors

STINNER Victor added the comment: Commited: r80404 (py3k), r80405 (3.1). -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue8124] mywrite() ignores PyFile_WriteString() errors

STINNER Victor added the comment: The goal is this issue is also to catch SIGINT when starting Python. It now works in Python trunk and py3k, but not in verbose mode because mywrite() eats errors (especially the KeyboardInterrupt raised by the default SIGINT handler) and calls indirectly Pyth

[issue8124] mywrite() ignores PyFile_WriteString() errors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file17044/pyfile_writeobject_nosignal.patch ___ Python tracker ___ ___ Python-

[issue8124] mywrite() ignores PyFile_WriteString() errors

STINNER Victor added the comment: Ok, forget my pyfile_writeobject_nosignal.patch, it's not the right approach. New patch: mywrite() uses its own implementation PyFile_WriteString(), sys_pyfile_write(), which doesn't call PyErr_CheckSignals(): /* Implementation of PyFile_WriteString() no cal

[issue8124] mywrite() ignores PyFile_WriteString() errors

STINNER Victor added the comment: Attached patch fixes this issue: PyFile_WriteObject() doesn't call PyObject_Str() to avoid PyErr_CheckSignals(). I'm not sure that it's the right approch because it may change the behaviour of existing code when getting a signal. -- keywords: +patch

[issue8124] mywrite() ignores PyFile_WriteString() errors

STINNER Victor added the comment: Another solution: disable call to PyErr_CheckSignals() in mywrite(). -- ___ Python tracker ___ ___ P

[issue8124] mywrite() ignores PyFile_WriteString() errors

STINNER Victor added the comment: This bug is related to #3137. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue8124] mywrite() ignores PyFile_WriteString() errors

New submission from STINNER Victor : PyFile_WriteString() calls PyObject_Str() which calls PyErr_CheckSignals(). If a signal was catched, the signal handler is called. If the signal handler raises an error, PyObject_Str() and then PyFile_WriteString() return NULL. mywrite() ignores all PyFile_