[issue8086] ssl.get_server_certificate new line missing

Antoine Pitrou added the comment: Fixed in r80557 (trunk) and r80558 (2.6). 3.1 and 3.2 weren't affected, but I still merged in the additional tests. Thank you! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed __

[issue8086] ssl.get_server_certificate new line missing

Antoine Pitrou added the comment: This looks reasonable enough. -- nosy: +pitrou stage: unit test needed -> patch review ___ Python tracker ___ __

[issue8086] ssl.get_server_certificate new line missing

Kyle VanderBeek added the comment: Forgot to note that my patch is against 2.7 current trunk. -- nosy: +kylev ___ Python tracker ___ _

[issue8086] ssl.get_server_certificate new line missing

Changes by Kyle VanderBeek : -- keywords: +patch Added file: http://bugs.python.org/file16672/python-ssl-PEM_FOOTER.patch ___ Python tracker ___ __

[issue8086] ssl.get_server_certificate new line missing

Changes by R. David Murray : -- nosy: +janssen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue8086] ssl.get_server_certificate new line missing

Changes by R. David Murray : -- versions: +Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8086] ssl.get_server_certificate new line missing

R. David Murray added the comment: I think that's because encodestring tacks a 'courtesy newline' on to the end of the output it returns. textwrap.fill does't, and I'm guessing that's the code path that your installation is taking. -- components: +Library (Lib) keywords: +easy nosy:

[issue8086] ssl.get_server_certificate new line missing

Chris added the comment: Did some more research and found this as the culprit: in Lib/ssl.py # ... def get_server_certificate(addr, ssl_version=PROTOCOL_SSLv3, ca_certs=None): ... return DER_cert_to_PEM_cert(dercert) def DER_cert_to_PEM_cert(der_cert_bytes):

[issue8086] ssl.get_server_certificate new line missing

New submission from Chris : I'm using ssl.get_server_certificate function. It returns a pem string. For each server I try, I get the string, but it is missing a newline "\n" before the -END CERTIFICATE- text. Any subsequent use of the string makes openssl throw up with a "bad end line"