[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Eryk Sun added the comment: > I don't understand why Python behaves differently in debug mode. > For me, if Python is able to trigger an exception on EINVAL, we > should also get a regular Python exception in debug mode (and not > a crash) The debug build's behavior isn't related to the inva

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

STINNER Victor added the comment: > Crashing happens only with the debug build. I don't understand why Python behaves differently in debug mode. For me, if Python is able to trigger an exception on EINVAL, we should also get a regular Python exception in debug mode (and not a crash). --

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Serhiy Storchaka added the comment: Crashing happens only with the debug build. With the release mode I got OSError(EINVAL). I think it is better to raise the same error in all builds. ValueError is not new, it is already raised for paths containing NUL and too long paths. -- _

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Eryk Sun added the comment: Serhiy, an empty file path shouldn't crash the interpreter. The per-thread invalid parameter handler is suppressed before calling _wspawnv, so it should raise OSError (EINVAL) if the file path is empty. That's what I observe in 3.7. Are you suggesting to raise Val

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Serhiy Storchaka added the comment: All three test cases are raising a VallueError now: C:\py\cpython3.8>python -c "import os; os.spawnl(os.P_WAIT, '')" Running Debug|x64 interpreter... Traceback (most recent call last): File "", line 1, in File "C:\py\cpython3.8\\lib\os.py", line 931, in

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Vetoshkin Nikita added the comment: added some tests (not sure if in appropriate place). -- Added file: http://bugs.python.org/file23529/issue_8036_1.patch ___ Python tracker ___

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Ezio Melotti added the comment: Now we are using Mercurial, and what was called 'py3k' on SVN is now 'default'. Since we now commit on older branches first and then merge with the most recent ones, the patch should either be against 3.2 or 2.7. You can check the devguide for more informations

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Vetoshkin Nikita added the comment: against py3k branch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

STINNER Victor added the comment: @nvetoshkin: Can you please also write tests (in Lib/test/test_os.py) for your patch? -- ___ Python tracker ___ ___

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Terry J. Reedy added the comment: This came up on python-list with os.spawnl (os.P_NOWAIT, r"c:\windows\notepad.exe") Tim Golden confirmed crash with Win7 on 2.7.? I did same with 3.2.2 in both interpreter and from IDLE (IDLE hangs and then restarts after closing the 'pythonw has stopped' error

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Changes by Terry J. Reedy : -- versions: +Python 3.3 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Vetoshkin Nikita added the comment: Attached first attempt to close this issue. Are there enough checks? It passes: os.spawnl(os.P_WAIT, '') os.spawnl(os.P_WAIT, 'path') os.spawnl(os.P_WAIT, 'path', '') -- keywords: +patch nosy: +nvetoshkin Added file: http://bugs.python.org/file21080/i

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Changes by Ralf Schmitt : -- nosy: +schmir ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Amaury Forgeot d'Arc added the comment: No, the issue can be fixed by better checking the arguments. -- ___ Python tracker ___ ___ Pyt

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

David Stanek added the comment: Should this just be resolved as a "won't fix"? -- nosy: +dstanek ___ Python tracker ___ ___ Python-bug

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Jean-Paul Calderone added the comment: Why is the Microsoft CRT argument error handler no longer disabled? -- nosy: +exarkun ___ Python tracker ___ __

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Amaury Forgeot d'Arc added the comment: 2.6 and 3.0.1 used to disable the Microsoft CRT argument error handler: they return EINVAL, but newer versions don't, and should check their arguments before calling _spawnv. FWIW, the checks are:: pathname != NULL *pathname != '\0' argv !=

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Amaury Forgeot d'Arc added the comment: Because this is a global setting for the whole process. This was discussed with issue4804. -- ___ Python tracker ___

[issue8036] Interpreter crashes on invalid arg to spawnl on Windows

Gabriel Genellina added the comment: In case it matters, 3.0.1 does NOT crash. -- nosy: +gagenellina ___ Python tracker ___ ___ Python