[issue7904] urlparse.urlsplit mishandles novel schemes

Senthil Kumaran added the comment: On Fri, Dec 03, 2010 at 10:33:50PM +, Fred L. Drake, Jr. wrote: > Though msg104261 suggests this change be documented in NEWS.txt, it > doesn't appear to have made it. Better late than never. I just added the NEWS in r87014 (py3k) ,r87015(release31-maint)

[issue7904] urlparse.urlsplit mishandles novel schemes

Fred L. Drake, Jr. added the comment: Though msg104261 suggests this change be documented in NEWS.txt, it doesn't appear to have made it. Sure enough, we just found application code that this broke. -- nosy: +fdrake ___ Python tracker

[issue7904] urlparse.urlsplit mishandles novel schemes

Éric Araujo added the comment: I remember seeing a discussion on python-dev archives about that months or years ago. Someone pointed to Guido that the new RFC removed the need for uses_netloc thanks to the generic syntax. Isn’t there already a bug about that? -- nosy: +merwok ___

[issue7904] urlparse.urlsplit mishandles novel schemes

Tres Seaver added the comment: The fix for this bug breaks any code which worked with non-standard schemes in 2.6.4 (by working around the issue). This kind of backward incompatibility should be called out prominently in NEWS.txt (assuming that such a fix is considered appropriate in a third-do

[issue7904] urlparse.urlsplit mishandles novel schemes

Senthil Kumaran added the comment: Fixed in the r78234 and merged back to other branches. I fell back to RFC's definition of scheme, as anything before the ://. I did not see the need to add s3 specifically as a valid scheme type, because s3 itself is not registered a schemetype. So, the fix sh

[issue7904] urlparse.urlsplit mishandles novel schemes

mARK added the comment: Doing a fallback test for // would look like if scheme in uses_netloc and url[:2] == '//' or url[:2] == '//': but this is equivalent to if url[:2] == '//': i.e., an authority appears if and only if there is a // after the scheme. This still allows a uses_netloc scheme

[issue7904] urlparse.urlsplit mishandles novel schemes

Changes by mARK : -- components: +Library (Lib) -Extension Modules versions: +Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-

[issue7904] urlparse.urlsplit mishandles novel schemes

mARK added the comment: The case which prompted this issue was a purely private set of URLs, sent to me by a client but never sent to Amazon or anywhere else outside our systems (though I'm sure many others have invented this particular scheme for their own use). It would have been convenien

[issue7904] urlparse.urlsplit mishandles novel schemes

R. David Murray added the comment: I think Mark is correct. RFC 3986 says: When authority is present, the path must either be empty or begin with a slash ("/") character. When authority is not present, the path cannot begin with two slash characters ("//"). I think it would make sense to h

[issue7904] urlparse.urlsplit mishandles novel schemes

Senthil Kumaran added the comment: Hello Mark, Thanks for the patch. However there are reasons why the check is: "if scheme in uses_netloc and url[:2] == '//':" It cannot be replaced by just url[:2] == '//' as in your patch. Different protocols have different parsing requirements. (for e.g.

[issue7904] urlparse.urlsplit mishandles novel schemes

mARK added the comment: i have attached an svn diff of my (very simple!) fix and added unit test for python 2.7. -- title: urllib.urlparse mishandles novel schemes -> urlparse.urlsplit mishandles novel schemes Added file: http://bugs.python.org/file16212/fix7904.txt _