[issue7838] Undocumented subprocess functions on Windows

Roundup Robot added the comment: New changeset 80971f71b0d9 by Brian Curtin in branch '3.1': Further fix #7838. CREATE_NEW_CONSOLE was exposed, but none of the http://hg.python.org/cpython/rev/80971f71b0d9 -- nosy: +python-dev ___ Python tracker

[issue7838] Undocumented subprocess functions on Windows

Brian Curtin added the comment: Fixed with r80439-r80442. -- assignee: georg.brandl -> brian.curtin components: +Extension Modules -Documentation resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracke

[issue7838] Undocumented subprocess functions on Windows

Brian Curtin added the comment: Here's a patch which keeps docstrings, and explicitly qualifies the Windows specific functions from _subprocess rather than using import * (which causes a couple of lines just over 79 chars). Now the functions are more hidden than before. Ran the tests to be s

[issue7838] Undocumented subprocess functions on Windows

Georg Brandl added the comment: I agree. Docstrings never hurt. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue7838] Undocumented subprocess functions on Windows

Benjamin Peterson added the comment: Actually, I consider them private now, given that they aren't in __all__ or documented. I'd prefer if the code was changed to qualify their use with _subprocess.X actually. Docstrings are fine, I suppose. -- status: pending -> open ___

[issue7838] Undocumented subprocess functions on Windows

Brian Curtin added the comment: True. Is there value in eventually privatizing these functions? It feels weird having them exposed but not documented at all...maybe just keep the docstrings around? -- status: open -> pending ___ Python tracker

[issue7838] Undocumented subprocess functions on Windows

Benjamin Peterson added the comment: This is likely because these functions are meant to be undocumented implementation details. -- nosy: +benjamin.peterson ___ Python tracker _

[issue7838] Undocumented subprocess functions on Windows

Changes by Brian Curtin : Added file: http://bugs.python.org/file16111/issue7838.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7838] Undocumented subprocess functions on Windows

Changes by Brian Curtin : Removed file: http://bugs.python.org/file16110/issue7838.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue7838] Undocumented subprocess functions on Windows

Brian Curtin added the comment: Attached is a patch which adds docstrings to the functions in PC/_subprocess.c, documents the functions in Doc/library/subprocess.rst, and removes a chunk of unneeded import code from Lib/subprocess.py -- keywords: +needs review, patch stage: needs patc

[issue7838] Undocumented subprocess functions on Windows

New submission from Brian Curtin : On Windows, the subprocess module makes use of functions publicly exposed by PC/_subprocess.c to interact with Win32 API functions. However, no documentation exists for these functions, neither in the online docs nor in docstrings. -- assignee: georg