[issue7820] parser: restores all bytes in the right order if check_bom() fails

STINNER Victor added the comment: Backported in r79197 (2.6). -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue7820] parser: restores all bytes in the right order if check_bom() fails

STINNER Victor added the comment: Commited: r78603 (trunk), r78608 (py3k), r78609 (3.1). Delay the fix in 2.6 after the release of 2.6.5. This issue is far from being critical, I don't want to introduce a regression after an RC :-) -- ___ Python tr

[issue7820] parser: restores all bytes in the right order if check_bom() fails

Changes by STINNER Victor : Removed file: http://bugs.python.org/file16068/parser_restore_bom-2.patch ___ Python tracker ___ ___ Python-bugs-li

[issue7820] parser: restores all bytes in the right order if check_bom() fails

STINNER Victor added the comment: > I think the test should be in test_pep263. Right! I always hesitate when adding a new test. -- Added file: http://bugs.python.org/file16072/parser_restore_bom-3.patch ___ Python tracker

[issue7820] parser: restores all bytes in the right order if check_bom() fails

Benjamin Peterson added the comment: I think the test should be in test_pep263. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue7820] parser: restores all bytes in the right order if check_bom() fails

STINNER Victor added the comment: > Are there test cases for this? Here you have. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue7820] parser: restores all bytes in the right order if check_bom() fails

Changes by STINNER Victor : Removed file: http://bugs.python.org/file16067/parser_restore_bom.patch ___ Python tracker ___ ___ Python-bugs-list

[issue7820] parser: restores all bytes in the right order if check_bom() fails

Changes by STINNER Victor : Added file: http://bugs.python.org/file16068/parser_restore_bom-2.patch ___ Python tracker ___ ___ Python-bugs-list

[issue7820] parser: restores all bytes in the right order if check_bom() fails

Benjamin Peterson added the comment: Are there test cases for this? -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs

[issue7820] parser: restores all bytes in the right order if check_bom() fails

New submission from STINNER Victor : My patch fixes check_bom() to restore all bytes in the right order if there is no BOM to leave the stream unchanged and to fix an assertion error in buf_ungetc() (raised in pydebug mode). The current code only unget one byte (0xFF), even if two or three byt