[issue754016] urlparse goes wrong with IP:port without scheme

Senthil Kumaran added the comment: New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in branch '3.8': [3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839) https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 -- __

[issue754016] urlparse goes wrong with IP:port without scheme

Change by Senthil Kumaran : -- pull_requests: +16389 pull_request: https://github.com/python/cpython/pull/16839 ___ Python tracker ___

[issue754016] urlparse goes wrong with IP:port without scheme

miss-islington added the comment: New changeset 82b5f6b16e051f8a2ac6e87ba86b082fa1c4a77f by Miss Islington (bot) in branch '3.7': bpo-27657: Fix urlparse() with numeric paths (GH-661) https://github.com/python/cpython/commit/82b5f6b16e051f8a2ac6e87ba86b082fa1c4a77f -- nosy: +miss-is

[issue754016] urlparse goes wrong with IP:port without scheme

Change by miss-islington : -- pull_requests: +16383 pull_request: https://github.com/python/cpython/pull/16837 ___ Python tracker ___ _

[issue754016] urlparse goes wrong with IP:port without scheme

Senthil Kumaran added the comment: New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim Graham) in branch 'master': bpo-27657: Fix urlparse() with numeric paths (#661) https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c87644a9034c969 -- ___

[issue754016] urlparse goes wrong with IP:port without scheme

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue754016] urlparse goes wrong with IP:port without scheme

Changes by Tim Graham : -- pull_requests: +544 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue754016] urlparse goes wrong with IP:port without scheme

Senthil Kumaran added the comment: Fixed in revision 83700 (release27-maint). r83701(py3k) and r83702(release31-maint). David, thanks for reworking on the patch. Couple of comments - I made change to the original patch where I checked 'https:' and 'http:' kind of url with url.endswith(':') i

[issue754016] urlparse goes wrong with IP:port without scheme

David Stanek added the comment: I've reworked the patch so that it applied against the py3k branch. It's been attached to this issue and is also available here: http://codereview.appspot.com/1910044. -- nosy: +dstanek Added file: http://bugs.python.org/file18362/754016.patch

[issue754016] urlparse goes wrong with IP:port without scheme

Mark Lawrence added the comment: The patch will need to be reworked for the 2.7, 3.1 and 3.2 branches. -- nosy: +BreamoreBoy versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___ Python tracker __

[issue754016] urlparse goes wrong with IP:port without scheme

Senthil added the comment: Facundo, I re-looked at this issue (after a long time; sorry for that) and I think that the patch is good to be applied as it is for this issue. The Web-SIG discussion, which you pointed to in the comment (http://mail.python.org/pipermail/web-sig/2008-June/003458.html

[issue754016] urlparse goes wrong with IP:port without scheme

Changes by Daniel Diniz : -- nosy: +jjlee stage: -> patch review type: -> behavior versions: +Python 2.6 -Python 2.3 ___ Python tracker ___ ___

[issue754016] urlparse goes wrong with IP:port without scheme

Facundo Batista <[EMAIL PROTECTED]> added the comment: I think this last patch is ok, but the third case that was raised in the web-sig should be addressed: """ There's even a 3rd case: HTTP's Request-URI. For example, '//path' must be treated as an abs_path consisting of two path_segments ['',

[issue754016] urlparse goes wrong with IP:port without scheme

Changes by Senthil <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10570/issue754016.patch ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue754016] urlparse goes wrong with IP:port without scheme

Senthil <[EMAIL PROTECTED]> added the comment: I am attaching the modified patch, which addresses the port issue properly and handles 'http:', 'https:' only URLS. Also included the tests for it. Facundo, I gave sufficient thought on raising an Exception for URLS not staring with '//', and I am -

[issue754016] urlparse goes wrong with IP:port without scheme

Facundo Batista <[EMAIL PROTECTED]> added the comment: I agree with Anthony here, because if you let people write without the "//" at the beginning, you'll never know if they're entering a net location or a relative path. So, the better behaviour to be as explicit as possible should be: >>> url

[issue754016] urlparse goes wrong with IP:port without scheme

Changes by Facundo Batista <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10686/test_urlparse.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue754016] urlparse goes wrong with IP:port without scheme

Anthony Lenton <[EMAIL PROTECTED]> added the comment: I agree with facundobatista that the patch is bad, but for a different reason: it now breaks with: >>> import urlparse >>> urlparse.urlparse ('http:') Traceback (most recent call last): File "", line 1, in File "/home/anthony/svn/python2

[issue754016] urlparse goes wrong with IP:port without scheme

Facundo Batista <[EMAIL PROTECTED]> added the comment: Senthil, your patch is wrong, see: >>> import urlparse >>> urlparse.urlparse('1.2.3.4:80','http') ParseResult(scheme='http', netloc='', path='1.2.3.4:80', params='', query='', fragment='') The netloc should be "1.2.3.4:80", note the composi

[issue754016] urlparse goes wrong with IP:port without scheme

Changes by Facundo Batista <[EMAIL PROTECTED]>: -- assignee: georg.brandl -> facundobatista ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue754016] urlparse goes wrong with IP:port without scheme

Senthil <[EMAIL PROTECTED]> added the comment: Attaching the patch to fix this issue. I deliberated upon this for a while and came up with the approach to: 1) fix the port issue, wherein urlparse should technically recognize the ':' separator for port from ':' after scheme. 2) And Doc fix wher