[issue7455] cPickle: stack underflow in load_pop()

STINNER Victor added the comment: > Committed in all four branches. trunk: r77352 -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue7455] cPickle: stack underflow in load_pop()

Antoine Pitrou added the comment: Committed in all four branches. Thank you Victor and Florent! -- nosy: +pitrou resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file15605/issue7455_silence_py3k_warning.diff ___ Python tracker ___ ___ Pyt

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : -- priority: -> normal stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : Added file: http://bugs.python.org/file15605/issue7455_silence_py3k_warning.diff ___ Python tracker ___ ___ Python

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file15596/issue7455_silence_py3k_warning.diff ___ Python tracker ___ ___ Pyt

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : Added file: http://bugs.python.org/file15604/issue7455_cpickle_load_pop_py3k.diff ___ Python tracker ___ ___ Pyth

[issue7455] cPickle: stack underflow in load_pop()

Florent Xicluna added the comment: I moved the test to test.pickletester, so that it can be used for all 3 tests: test_pickle test_cpickle test_xpickle (and backported a test which was only on py3k) -- Added file: http://bugs.python.org/file15603/issue7455_cpickle_load_pop.diff ___

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : Added file: http://bugs.python.org/file15596/issue7455_silence_py3k_warning.diff ___ Python tracker ___ ___ Python

[issue7455] cPickle: stack underflow in load_pop()

Changes by Florent Xicluna : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue7455] cPickle: stack underflow in load_pop()

Florent Xicluna added the comment: The patch works correctly on 2.7. It should be applied on trunk, and backported to other branches, too. (issue7542 is marked as duplicate of this one) -- nosy: +flox versions: +Python 2.6, Python 3.1, Python 3.2 _

[issue7455] cPickle: stack underflow in load_pop()

Jack Diederich added the comment: This seems to have been introduced in r72930 when the stackUnderflow() was moved from the top of the function to the bottom. It used to test for len > 0. Question, should cPickle and pickle be raising the same error here? UnpicklingError is defined in pickle.

[issue7455] cPickle: stack underflow in load_pop()

Changes by Antoine Pitrou : -- nosy: +alexandre.vassalotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue7455] cPickle: stack underflow in load_pop()

STINNER Victor added the comment: Oops, cpickle_load_pop-2.patch contains an useless variable (picklingError = pickle.UnpicklingError). Here is the version 3 of my patch. -- Added file: http://bugs.python.org/file15524/cpickle_load_pop-3.patch ___ P

[issue7455] cPickle: stack underflow in load_pop()

Changes by STINNER Victor : Removed file: http://bugs.python.org/file15494/cpickle_load_pop-2.patch ___ Python tracker ___ ___ Python-bugs-list

[issue7455] cPickle: stack underflow in load_pop()

Changes by STINNER Victor : Removed file: http://bugs.python.org/file15487/cpickle_load_pop.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue7455] cPickle: stack underflow in load_pop()

STINNER Victor added the comment: > Can you add a test for this? I wasn't sure of the right place to add the test. I tried Lib/test/pickletester.py, but it doesn't work because UnpicklingError is not defined there. Well, here is a new version of my patch with an unit test. -- Added fi

[issue7455] cPickle: stack underflow in load_pop()

Eric Smith added the comment: Can you add a test for this? -- nosy: +eric.smith stage: -> test needed ___ Python tracker ___ ___ Pyth

[issue7455] cPickle: stack underflow in load_pop()

New submission from STINNER Victor : load_pop() pops a value if the stack length is >= 0. The test is wrong: if the length is zero, the stack is empty and stackUnderflow() have to be called. Example: $ ../../python -c "import cPickle; cPickle.loads('0')" Erreur de segmentation -- c