[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Roundup Robot added the comment: New changeset 3f9b3b6f7ff0 by Stefan Krah in branch 'default': - Issue #10181: New memoryview implementation fixes multiple ownership http://hg.python.org/cpython/rev/3f9b3b6f7ff0 -- nosy: +python-dev ___ Python track

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Stefan Krah added the comment: Closing, since it's fixed in #10181. -- dependencies: -Problems with Py_buffer management in memoryobject.c (and elsewhere?) resolution: -> duplicate stage: needs patch -> committed/rejected status: open -> closed superseder: -> Problems with Py_buffer

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Stefan Krah added the comment: My last comment could be misinterpreted: This *is* actually already fixed in features/pep-3118. -- versions: +Python 3.3 -Python 3.1 ___ Python tracker ___

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Changes by Mark Dickinson : -- assignee: mark.dickinson -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Changes by Meador Inge : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Stefan Krah added the comment: This should be fixed in features/pep-3118. -- dependencies: +Problems with Py_buffer management in memoryobject.c (and elsewhere?) nosy: +skrah ___ Python tracker ___

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Changes by Antoine Pitrou : -- assignee: -> mark.dickinson nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Changes by Meador Inge : -- nosy: +minge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

STINNER Victor added the comment: > I can try to cook up a patch fixing this. Did you wrote something? I don't see any patch attached to this issue :-/ -- nosy: +haypo ___ Python tracker __

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Antoine Pitrou added the comment: > To work around this, *_releasebuf must be written so that it does not > use the "view" pointer passed to it -- the data structure may have been > shallow copied and any memory pointers in it may have already been freed. > > I can try to cook up a patch fixing

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Pauli Virtanen added the comment: I think this is an implementation issue in MemoryView rather than an issue with the buffer interface. PEP 3118 states, "This same bufferinfo structure must be passed to bf_releasebuffer (if available) when the consumer is done with the memory." -- this is not gu

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Antoine Pitrou added the comment: > I was probably thinking about allocating new temporary arrays for > strides etc. on each *_getbuffer -- if that's done, then manually > keeping track of all the allocated memory seems like a waste of effort > (ie. not feasible). Yes, I know it looks very pain

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Pauli Virtanen added the comment: > Why do you say that: > > > There is no feasible way the bf_releasebuffer can keep track of how > > many calls to it have been made. I was probably thinking about allocating new temporary arrays for strides etc. on each *_getbuffer -- if that's done, then ma

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Antoine Pitrou added the comment: Why do you say that: > There is no feasible way the bf_releasebuffer can keep track of how many > calls to it have been made. Because that's exactly what e.g. bytearray objects do (see the ob_exports field in Objects/bytearrayobject.c). -- nosy: +pitr

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

Changes by Pauli Virtanen : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue7433] MemoryView memory_getbuf causes segfaults, double call to tp_releasebuffer

New submission from Pauli Virtanen : The following code causes a segmentation fault (or glibc error, or other problems): >>> x = someobject() >>> y = memoryview(x) >>> z = memoryview(y) The problem is that someobject.bf_releasebuffer will be called two times with an identical Py_buffer structur