[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Antoine Pitrou added the comment: Patch committed in r84394 (py3k) and r84396 (3.1). Thank you Stefan! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Stefan Behnel added the comment: When I read the comments and exception texts in the function, it didn't occur to me that "char buffer" could have been used as a name for the old Py2 buffer interface. From the context, it totally makes sense to me that the function (which decodes a byte seque

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Marc-Andre Lemburg added the comment: Stefan Behnel wrote: > > Stefan Behnel added the comment: > > Another updated patch with a readability fix (replacing the last one). While you're at it, you might as well remove references to the "char buffer" - there's no such thing in Python3 anymore.

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Stefan Behnel added the comment: Another updated patch with a readability fix (replacing the last one). -- Added file: http://bugs.python.org/file18589/unicodeobject-PyUnicode_FromEncodedObject-buffer-refactored.patch ___ Python tracker

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Changes by Stefan Behnel : Removed file: http://bugs.python.org/file18588/unicodeobject-PyUnicode_FromEncodedObject-buffer-refactored.patch ___ Python tracker ___ ___

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Stefan Behnel added the comment: ... and another complete patch that refactors the complete function to make it clearer what happens. Includes a small code duplication for the bytes object case, which I think it acceptable. -- Added file: http://bugs.python.org/file18588/unicodeobjec

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Antoine Pitrou added the comment: > Doesn't the GIL protect the bytearray buffer? Or does decoding free the GIL? Well, decoding can call arbitrary Python code and therefore, yes, release the GIL. Ironically, PyUnicode_Decode() itself (called from PyUnicode_FromEncodedObject()) fills a dummy Py

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Stefan Behnel added the comment: Regardless of the answer, I think Antoine is right, special cases aren't special enough to break the rules, and this is a special case that's more safely handled as part of the normal buffer case. Updated patch uploaded. -- Added file: http://bugs.py

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Stefan Behnel added the comment: Doesn't the GIL protect the bytearray buffer? Or does decoding free the GIL? -- versions: +Python 2.7 ___ Python tracker ___

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Antoine Pitrou added the comment: I think the bytearray special-casing should be removed. Otherwise one can reallocate the buffer in another thread while it is being used for decoding. -- nosy: +pitrou versions: -Python 2.7 ___ Python tracker

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Stefan Behnel added the comment: Here's a patch against the latest py3k. The following will call the new code, for example: str(memoryview(b'abc'), 'ASCII') whereas bytes and bytesarray continue to use their own special casing code (which has also changed a bit since I wanted to avoid code

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

Mark Lawrence added the comment: @Stefan can you provide a patch for this? -- nosy: +BreamoreBoy stage: -> needs patch versions: +Python 2.7 -Python 3.0 ___ Python tracker ___ _

[issue7415] PyUnicode_FromEncodedObject() uses PyObject_AsCharBuffer()

New submission from Stefan Behnel : PyUnicode_FromEncodedObject() currently calls PyObject_AsCharBuffer() to get the buffer pointer and length of a buffer supporting object. It should be changed to support the buffer protocol correctly instead. I filed this as a crash bug as the buffer protocol