[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

Changes by Benjamin Peterson : -- resolution: -> works for me status: open -> closed ___ Python tracker ___ ___ Python-bugs-list maili

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

Jon Parise added the comment: That's true. I thought it worked the same as the ADD_INT() macro I replaced, but I see that I was wrong. Given that, perhaps the original code is best. I don't see a lot of value in replacing PyModule_AddIntConstant() with PyModule_AddIntMacro() within ADD_INT().

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

Benjamin Peterson added the comment: You don't account for PyModule_AddIntMacro failing. -- nosy: +benjamin.peterson ___ Python tracker ___ __

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

Changes by Jon Parise : Added file: http://bugs.python.org/file15379/gc_macros-py3k.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

New submission from Jon Parise : The attached patch uses PyModule_AddIntMacro() to register the gc module's constants instead of using a local ADD_INT() macro. -- components: Interpreter Core files: gc_macros-trunk.patch keywords: patch messages: 95589 nosy: jon severity: normal status: