[issue7351] Rename BadZipfile to BadZipFile for consistency

Changes by Éric Araujo : Removed file: http://bugs.python.org/file19399/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue7351] Rename BadZipfile to BadZipFile for consistency

Boštjan Mejak added the comment: Then disable the tracker's ability to post messages via POP/IMAP. Just block those protocols in the tracker and you won't see any gibberish anymore. ;) On Thu, Oct 28, 2010 at 4:05 PM, Éric Araujo wrote: > > Éric Araujo added the comment: > > > Is the trai

[issue7351] Rename BadZipfile to BadZipFile for consistency

Éric Araujo added the comment: > Is the trailing whitespace problem solved? You can follow the link to the revision to see that it is. Georg’s message implied this, too. > Please make sure everything is correct and that no more typos occur for this > issue. We do. > And I am the original pa

[issue7351] Rename BadZipfile to BadZipFile for consistency

Georg Brandl added the comment: a) I already removed the whitespace before committing. The pre-commit hook wouldn't even allow committing that. b) I don't think constant refusal to submit a patch in the way we request earns you a place in the acknowledgements. -- __

[issue7351] Rename BadZipfile to BadZipFile for consistency

Changes by Éric Araujo : Removed file: http://bugs.python.org/file19397/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue7351] Rename BadZipfile to BadZipFile for consistency

Changes by Éric Araujo : Removed file: http://bugs.python.org/file19388/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue7351] Rename BadZipfile to BadZipFile for consistency

Boštjan Mejak added the comment: Is the trailing whitespace problem solved? Please make sure everything is correct and that no more typos occur for this issue. And I am the original patch author, so mention my name (Boštjan Mejak) in the NEWS file. Thanks. On Thu, Oct 28, 2010 at 8:42 AM, Geo

[issue7351] Rename BadZipfile to BadZipFile for consistency

Georg Brandl added the comment: Thanks for the catch! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue7351] Rename BadZipfile to BadZipFile for consistency

Éric Araujo added the comment: A “BadZipZile” in the patch made it to Subversion :) Fixed in r85891. -- ___ Python tracker ___ ___ Py

[issue7351] Rename BadZipfile to BadZipFile for consistency

Georg Brandl added the comment: Applied after review in r85874. (Please make sure your patches don't have trailing whitespace.) -- ___ Python tracker ___ ___

[issue7351] Rename BadZipfile to BadZipFile for consistency

Changes by Georg Brandl : -- Removed message: http://bugs.python.org/msg119757 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7351] Rename BadZipfile to BadZipFile for consistency

Georg Brandl added the comment: Applied after review in r85873. (Please make sure your patches don't have trailing whitespace.) -- resolution: -> fixed status: open -> closed ___ Python tracker __

[issue7351] Rename BadZipfile to BadZipFile for consistency

Stephen Hansen added the comment: Oh: and I tested it against branches/py3k in the head, it applies cleanly and builds, and test_zipfile runs without error. -- ___ Python tracker __

[issue7351] Rename BadZipfile to BadZipFile for consistency

Stephen Hansen added the comment: Considering I do use zipfiles a lot, I slightly care about this (at least, eventually)-- I'm attaching a new patch, with doc and test changes as well (and the compatibility alias). What convinced me was looking at test_zipfile, and noticing how often it actu

[issue7351] Rename BadZipfile to BadZipFile for consistency

Boštjan Mejak added the comment: No alias. Be stubborn and let the stdlib die in inconsistency. On Thu, Oct 28, 2010 at 2:11 AM, Stephen Hansen wrote: > > Stephen Hansen > added the > comment: > > You may "not care" about backwards compatibility, but introducing a > breaking change in 3.2 for

[issue7351] Rename BadZipfile to BadZipFile for consistency

Stephen Hansen added the comment: You may "not care" about backwards compatibility, but introducing a breaking change in 3.2 for mere style-conformity is not OK, IMO. If the patcher insists on it being a breaking change, it should be rejected. FWIW, this casing is sufficiently bizarre and inc

[issue7351] Rename BadZipfile to BadZipFile for consistency

Changes by Boštjan Mejak : Removed file: http://bugs.python.org/file19387/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue7351] Rename BadZipfile to BadZipFile for consistency

Boštjan Mejak added the comment: I am -1 for the alias. I want that this gets renamed in Python 3.2, not aliased. I don't care about old pickles. Anyway, who has BadZipfile object pickled? Just incorporate my patch and fix the docs and any test cases/units. Thanks. On Wed, Oct 27, 2010 at 10:4

[issue7351] Rename BadZipfile to BadZipFile for consistency

Éric Araujo added the comment: Boštjan, you need to update your patch to add the missing alias to the old name, as well as docs and test updates. I’m +0 on the change. -- stage: committed/rejected -> patch review title: Documentation typos found in "zipfile — Work with ZIP archives" -