[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-04-21 Thread Brian Curtin
Brian Curtin added the comment: Ported to py3k in r80329. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ P

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-04-02 Thread Brian Curtin
Brian Curtin added the comment: Committed to trunk in r79620. I'll do the forward port after 2.7b1. -- stage: patch review -> committed/rejected ___ Python tracker ___ __

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-03-31 Thread Brian Curtin
Brian Curtin added the comment: Gabriel, besides the *Ex naming, do you see anything wrong with the rest of the patch? I'd like to try and get this into 2.7 before the upcoming beta. -- ___ Python tracker

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-03-20 Thread Brian Curtin
Brian Curtin added the comment: RegDeleteKeyEx will only work on a Windows version of 5.2 or greater (Vista/XP x64), and XP is 5.1, so RegDeleteKeyEx can't be a simple drop-in under the "DeleteKey" name. CreateKeyEx is different though since it goes as far back as Win2k, and it could be put

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-03-19 Thread Gabriel Genellina
Gabriel Genellina added the comment: Why the *Ex names? Can't we just add additional arguments to the original names? The Python names do not necesarily have to match the API calls. Having QueryValue and QueryValueEx was a mistake in the first place, and I would prefer not continuing doing su

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-03-15 Thread Brian Curtin
Brian Curtin added the comment: Fixed a few a/an word changes and a few tab/space issues. Re-uploaded to Rietveld at http://codereview.appspot.com/580041 -- Added file: http://bugs.python.org/file16558/issue7347.diff ___ Python tracker

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-03-15 Thread Brian Curtin
Changes by Brian Curtin : Removed file: http://bugs.python.org/file16156/issue7347.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-03-01 Thread Brian Curtin
Brian Curtin added the comment: I've uploaded the patch to http://codereview.appspot.com/223088 -- ___ Python tracker ___ ___ Python-b

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-02-06 Thread Brian Curtin
Brian Curtin added the comment: Attached is what I believe is the complete patch. You'll need to apply the patch on #7860 for proper test coverage of a 32-bit Python running on 64-bit Windows. Here's a summary of what's contained: 1. Documented and tested the previously undocumented and unte

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-02-06 Thread Brian Curtin
Brian Curtin added the comment: This needs #7860 for properly figuring out the machine architecture for some 32-bit Python on 64-bit Windows tests. -- dependencies: +32-bit Python on 64-bit Windows reports incorrect architecture ___ Python tracker

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-01-24 Thread Brian Curtin
Brian Curtin added the comment: After looking into this again, the testing situations are much different than I had originally written. Some of the tests aren't really valid exercises. For one, the querying/enabling/disabling of reflection keys aren't good tests as they aren't tested against

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-01-12 Thread Brian Curtin
Changes by Brian Curtin : -- priority: -> normal stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2009-11-20 Thread Brian Curtin
Brian Curtin added the comment: After looking at this more, I poked around and found a whole lot of things either missing or broken with _winreg. Changes: - documentation missing for *ReflectionKey, and updated a few incorrectly documented exceptions in the docstrings - QueryReflectionKey alway