[issue7120] logging depends on multiprocessing

2009-10-16 Thread Vinay Sajip
Vinay Sajip added the comment: Fix checked into trunk and py3k (r75445). -- status: pending -> closed ___ Python tracker ___ ___ Pytho

[issue7120] logging depends on multiprocessing

2009-10-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Please apply this for 2.6.4rc2 -- priority: -> release blocker resolution: fixed -> accepted status: pending -> open ___ Python tracker ___ __

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Vinay Sajip
Changes by Vinay Sajip : -- nosy: +barry status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Jesse Noller
Jesse Noller added the comment: >The addition of multiprocessing support to logging seems to have happened > in 2.6.2; bad timing for a feature. :-( Just in minor self-defense, this wasn't a feature, it was a bug fix. The original multiprocessing code base relied on some unfortunate monkey-

[issue7120] logging depends on multiprocessing

2009-10-14 Thread R. David Murray
R. David Murray added the comment: On Wed, 14 Oct 2009 at 21:46, Vinay Sajip wrote: > Vinay Sajip added the comment: >> Guido van Rossum added the comment: >> >> (I don't know why the tracker reopened the issue when I added a comment. >> Anyway, is the fix going into 2.6.4 or will it have to w

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Vinay Sajip
Vinay Sajip added the comment: > Guido van Rossum added the comment: > > (I don't know why the tracker reopened the issue when I added a comment. > Anyway, is the fix going into 2.6.4 or will it have to wait for 2.6.5?) That's OK, I'll close it once I've made the same changes in trunk and p

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Guido van Rossum
Guido van Rossum added the comment: (I don't know why the tracker reopened the issue when I added a comment. Anyway, is the fix going into 2.6.4 or will it have to wait for 2.6.5?) -- ___ Python tracker __

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Guido van Rossum
Guido van Rossum added the comment: Confirmed, the stack limit error is gone now. Thanks!! (There's another error, the import of _scproxy from urllib, but that's easily added to the App Engine SDK's whitelist. I am still concerned about the amount of change in the 2.6 branch, but the cat is o

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Vinay Sajip
Vinay Sajip added the comment: Fix checked into release26-maint (r75425). Please verify in GAE environment, will make same fix in trunk and py3k once verified. Fixed based on Antoine's message, though not identical to his posted code. -- resolution: -> fixed status: open -> pending _

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: `self.processName` could be a lazily computed property, since it doesn't seem to be used anywhere by default. Something like: _processName = None @property def processName(self): n = self._processName if n is not None: r

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Vinay Sajip
Vinay Sajip added the comment: > Whatever the value of logMultiprocessing is, I suggest to not import the > multiprocessing module if the application did not import it before: > something like: > > if "multiprocessing" in sys.modules: > from multiprocessing import current_process >

[issue7120] logging depends on multiprocessing

2009-10-14 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Whatever the value of logMultiprocessing is, I suggest to not import the multiprocessing module if the application did not import it before: something like: if "multiprocessing" in sys.modules: from multiprocessing import current_process

[issue7120] logging depends on multiprocessing

2009-10-13 Thread Vinay Sajip
Vinay Sajip added the comment: I propose to fix it by just setting logRecord.processName to None for now, which is what should happen if multiprocessing isn't available. In environments where multiprocessing is not available, logging.logMultiprocessing should be False, but that fix needs to go

[issue7120] logging depends on multiprocessing

2009-10-13 Thread Guido van Rossum
Guido van Rossum added the comment: The addition of multiprocessing support to logging seems to have happened in 2.6.2; bad timing for a feature. :-( -- title: 2.6.4rc1 regression -> logging depends on multiprocessing ___ Python tracker