[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Use os.path.sep and os.path.sep.encode() instead of hardcoding "/" and > b"/". Some separators will be '\\' (if they are derived from OS functions, i.e. getcwd), and some will be '/' (if they are generated by posixpath). I do not have the ability to resear

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-20 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Use os.path.sep and os.path.sep.encode() instead of hardcoding "/" and b"/". -- ___ Python tracker ___ _

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have no access to Windows and can't design Windows tests. -- ___ Python tracker ___ ___ Python-bu

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-19 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: You could probably test '.\\.' and '..\\..' etc. in these tests on Windows. -- ___ Python tracker ___ __

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3c5517c4fa5d by Serhiy Storchaka in branch '2.7': Disable posixpath.realpath() tests on Windows (fix for issue #6975). http://hg.python.org/cpython/rev/3c5517c4fa5d New changeset 0bbf7cdea551 by Serhiy Storchaka in branch '3.2': Disable posixpath.re

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-18 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 50ed06b3d419 by Serhiy Storchaka in branch '2.7': Fix posixpath.realpath() for multiple pardirs (fixes issue #6975). http://hg.python.org/cpython/rev/50ed06b3d419 New changeset cb3fbadb65aa by Serhiy Storchaka in branch '3.2': Fix posixpath.realpath

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for the report. I'm surprised that the tests are not caught it. -- ___ Python tracker ___ ___

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-17 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: The actual output of last command in "Before these revisions:" is: / -- ___ Python tracker ___ _

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-17 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: The above revisions have broken handling of arguments with >=2 "..". Before these revisions: $ cd /usr/bin $ python3.2 -c 'import os; print(os.path.realpath(".."))' /usr $ python3.2 -c 'import os; print(os.path.realpath("../.."))' / $ pytho

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-10 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6ec6dbf787f4 by Serhiy Storchaka in branch '2.7': Issue #6975: os.path.realpath() now correctly resolves multiple nested symlinks on POSIX platforms. http://hg.python.org/cpython/rev/6ec6dbf787f4 New changeset c5f4fa02fc86 by Serhiy Storchaka in br

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-01-14 Thread Marco Buccini
Changes by Marco Buccini : -- nosy: -markon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-01-14 Thread R. David Murray
R. David Murray added the comment: Vis the discussion of x[:0] in the review. This kind of construct is only unfamiliar because it is new in Python3, and there are not *that* many places that you want to (and can) deal with both bytes and strings using the same code. But when you can, it is

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-01-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I don't really understand your algorithm. Why do you need a stack? Before resolving the symlink we mark the path as unresolved symlink for detecting infinite symlink loops. Before resolving the symlink we mark the path as resolved symlink (and cache the re

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-01-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't really understand your algorithm. Why do you need a stack? It should be simply iterative: - if the symlink is relative, prepend the symlink target to the rest - if the symlink is absolute, discard the current path and prepend the symlink target to the r

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-01-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch rewritten using recursion. Non-recursive version is not stack limited (and a little faster), but recursive version is perhaps more understandable. Some comments added. -- Added file: http://bugs.python.org/file28672/posix_realpath_2.patch

[issue6975] symlinks incorrectly resolved on POSIX platforms

2013-01-10 Thread Hynek Schlawack
Changes by Hynek Schlawack : -- title: symlinks incorrectly resolved on Linux -> symlinks incorrectly resolved on POSIX platforms ___ Python tracker ___ _