[issue6845] Restart support in binary upload for ftplib

Antoine Pitrou added the comment: The patch has been committed in r76546 and r76547. Thank you for your contribution! -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue6845] Restart support in binary upload for ftplib

Changes by Pablo Mouzo : Added file: http://bugs.python.org/file15402/issue6845-py3k.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue6845] Restart support in binary upload for ftplib

Pablo Mouzo added the comment: Thanks Antoine, I'm attaching both patches. Now the test isn't failing. -- Added file: http://bugs.python.org/file15401/issue6845-trunk.diff ___ Python tracker ___

[issue6845] Restart support in binary upload for ftplib

Changes by Pablo Mouzo : Removed file: http://bugs.python.org/file15302/issue6845-trunk.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue6845] Restart support in binary upload for ftplib

Antoine Pitrou added the comment: Now that FTP_TLS has been integrated into the trunk, the patch should be augmented in order to also cover that class. Right now a test is failing: == ERROR: test_storbinary_rest (test.test_ftpl

[issue6845] Restart support in binary upload for ftplib

Changes by Pablo Mouzo : Removed file: http://bugs.python.org/file15027/issue6845.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue6845] Restart support in binary upload for ftplib

Pablo Mouzo added the comment: Here is a new patch. It works with both ints and strings. I'm working on a patch for py3k. -- Added file: http://bugs.python.org/file15302/issue6845-trunk.diff ___ Python tracker ___

[issue6845] Restart support in binary upload for ftplib

Antoine Pitrou added the comment: > I think that a non-digit REST argument is an error. But I've tested some > ftp servers and they don't return an error code, they just set REST to 0 > and return some OK code. Finally, ftplib doesn't check that, so if > someone accidentally passes a non-digit a

[issue6845] Restart support in binary upload for ftplib

Giampaolo Rodola' added the comment: The patch looks good to me. Only two little remarks: 1: I'd create two new separate tests rather than appending them to existent ones. 2: > self.client.retrbinary('retr', received.append, rest=str(rest)) str() should be useless here. > According to the RF

[issue6845] Restart support in binary upload for ftplib

Pablo Mouzo added the comment: I think that a non-digit REST argument is an error. But I've tested some ftp servers and they don't return an error code, they just set REST to 0 and return some OK code. Finally, ftplib doesn't check that, so if someone accidentally passes a non-digit argument it

[issue6845] Restart support in binary upload for ftplib

Antoine Pitrou added the comment: According to the RFC, the argument to REST can be any string of printable characters. However, does it happen for clients to put non-digits in there? (that is, are there any implementations where the argument to REST is something else than the byte offset from t

[issue6845] Restart support in binary upload for ftplib

Changes by Antoine Pitrou : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue6845] Restart support in binary upload for ftplib

Changes by Antoine Pitrou : -- components: +Library (Lib) -None priority: -> normal stage: -> patch review versions: +Python 3.2 ___ Python tracker ___ _

[issue6845] Restart support in binary upload for ftplib

Changes by Antoine Pitrou : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue6845] Restart support in binary upload for ftplib

Changes by Pablo Mouzo : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue6845] Restart support in binary upload for ftplib

Changes by Pablo Mouzo : Removed file: http://bugs.python.org/file14876/issue6845.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue6845] Restart support in binary upload for ftplib

Pablo Mouzo added the comment: I attached some tests. -- Added file: http://bugs.python.org/file15027/issue6845.diff ___ Python tracker ___ __

[issue6845] Restart support in binary upload for ftplib

Facundo Batista added the comment: I like this. I'd love to see a test of this, though. Pablo, do you think you could came up with a test? Thanks! -- ___ Python tracker ___

[issue6845] Restart support in binary upload for ftplib

Changes by Alejandro Santos : -- nosy: +alejolp ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue6845] Restart support in binary upload for ftplib

Pablo Mouzo added the comment: I'm changing the title to something clearer (I hope). The patch I submitted adds the retr optional parameter to the storbinary method. -- title: ftplib rest support for storbinary -> Restart support in binary upload for ftplib Added file: http://bugs.pyth