[issue6790] httplib and array do not play together well

Antoine Pitrou added the comment: Committed in r75134, r75135, r75137, r75142. Thanks! -- resolution: accepted -> fixed status: open -> closed ___ Python tracker ___

[issue6790] httplib and array do not play together well

Changes by Antoine Pitrou : -- assignee: -> pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue6790] httplib and array do not play together well

Antoine Pitrou added the comment: issue6790-python2.6.diff is ok, can you commit to trunk and then merge? -- resolution: -> accepted ___ Python tracker ___ _

[issue6790] httplib and array do not play together well

Changes by Kirk McDonald : Removed file: http://bugs.python.org/file14991/issue6790-python2.6.diff ___ Python tracker ___ ___ Python-bugs-list

[issue6790] httplib and array do not play together well

Kirk McDonald added the comment: Remove unused 'body'. -- Added file: http://bugs.python.org/file14992/issue6790-python2.6.diff ___ Python tracker ___ ___

[issue6790] httplib and array do not play together well

Kirk McDonald added the comment: Oh, I suppose I don't. I had simply copy and pasted those four lines from the previous method. That line could easily be removed. -- ___ Python tracker

[issue6790] httplib and array do not play together well

Antoine Pitrou added the comment: Why do you need to give a non-empty body to the FakeSocket? Other than that, looks fine. -- ___ Python tracker ___ ___

[issue6790] httplib and array do not play together well

Changes by Kirk McDonald : Removed file: http://bugs.python.org/file14978/issue6790-python2.6.diff ___ Python tracker ___ ___ Python-bugs-list

[issue6790] httplib and array do not play together well

Kirk McDonald added the comment: I have updated the patch with a unittest for httplib.HTTPConnection.send. -- Added file: http://bugs.python.org/file14991/issue6790-python2.6.diff ___ Python tracker ___

[issue6790] httplib and array do not play together well

Antoine Pitrou added the comment: These methods don't even produce a DeprecationWarning in current 2.6, I don't think it's ok to remove them. As for the special casing patch, it would be better with a test. -- nosy: +pitrou ___ Python tracker

[issue6790] httplib and array do not play together well

Kirk McDonald added the comment: Here is a patch special-casing array.array in httplib.HTTPConnection.send in Python 2.6. -- keywords: +patch nosy: +KirkMcDonald Added file: http://bugs.python.org/file14978/issue6790-python2.6.diff ___ Python tracke

[issue6790] httplib and array do not play together well

Kirk McDonald added the comment: And here is a patch removing the array.array.read and .write methods in 2.7. -- Added file: http://bugs.python.org/file14979/issue6790-python2.7.diff ___ Python tracker ___

[issue6790] httplib and array do not play together well

R. David Murray added the comment: That method of array.array has been deprecated since 1.5.1 according to the docs. Too bad nobody finished the job and removed it. Perhaps array.array could be special cased in the relevant code until the method can actually be removed. -- keywords: +

[issue6790] httplib and array do not play together well

New submission from Jake McGuire : As of Python 2.6 you can no longer pass an array to httplib.HTTPConnection.send. Issue1065257 added code to httplib to attempt to determine whether a file-like object was passed to certain methods (e.g. send), and to stream the data if so. The patch uses "h